Simplify Quickstart #281
Merged
Simplify Quickstart #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Since we have /catalog/upload_from_url API now (machine-learning-exchange#259), we no longer need to keep a copy of the catalog_upload.json file under quickstart * Since all assets get published and featured automatically with catalog upload (machine-learning-exchange#256), there is no longer a need for the init_catalog.sh script either * Since the MLX API also creates the Pipelines table (3c10fda) we no longer need to mount the init_db.sql to the mysql service * Since the Docker Compose File v3+ spec no longer supports condition as an option of depends_on we no longer need the healthcheck on services, but instead have to use simple while-wait-loops in the commands of downstream services Related machine-learning-exchange#256 Related machine-learning-exchange#259 Related 3c10fda Related https://forums.docker.com/t/depends-on-version-3/29463 Signed-off-by: Christian Kadner <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Besides simplifying the docker-compose.yaml file and removing duplicated files, another benefit of this change is that first time users no longer have to clone the These two lines are sufficient: wget https://raw.githubusercontent.com/ckadner/mlx/simplify_quickstart/quickstart/docker-compose.yaml
docker compose up |
|
/lgtm |
|
Thanks @Tomcli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
/catalog/upload_from_urlAPI now (Added upload-from-url to catalog service #259), we no longer need to keep a copy of thecatalog_upload.jsonfile underquickstartpublishedandfeaturedautomatically with catalog upload (Feature all assets from catalog upload #256), there is no longer a need for theinit_catalog.shscript eitherinit_db.sqlto themysqlservicedepends_onwe no longer need thehealthcheckon services, but instead have to use simple while-sleep-loops in the commands of downstream servicesAnother benefit of this change is, that first time users no longer have to clone the
machine-learning-exchange/mlxGithub repo in order to run the Quickstart:These two lines are sufficient:
Related Issues:
FYI @girigsrini -- these are the changes under
quickstartafter you rework your PR #262 to address the changes underbootstrapper