Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added upload-from-url to catalog service #259

Merged

Conversation

JAulet
Copy link
Contributor

@JAulet JAulet commented Nov 11, 2021

Resolves #236

Signed-off-by: JAulet [email protected]

@JAulet
Copy link
Contributor Author

JAulet commented Nov 11, 2021

@ckadner please review

@JAulet JAulet force-pushed the upload-catalog-from-url branch from 6e6b466 to 5912178 Compare November 11, 2021 00:49
@ckadner ckadner requested review from ckadner and removed request for animeshsingh November 11, 2021 00:50
@ckadner ckadner added the RCOS Potential work items for RCOS student interns label Dec 1, 2021
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mlx-bot
Copy link
Collaborator

mlx-bot commented Dec 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, JAulet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mlx-bot mlx-bot merged commit 9e5ecf6 into machine-learning-exchange:main Dec 2, 2021
ckadner added a commit to ckadner/mlx that referenced this pull request Dec 2, 2021
* Since we have /catalog/upload_from_url API now (machine-learning-exchange#259), we
  no longer need to keep a copy of the catalog_upload.json
  file under quickstart
* Since all assets get published and featured automatically
  with catalog upload (machine-learning-exchange#256), there is no longer a need for
  the init_catalog.sh script either
* Since the MLX API also creates the Pipelines table (3c10fda)
  we no longer need to mount the init_db.sql to the mysql
  service
* Since the Docker Compose File v3+ spec no longer supports
  condition as an option of depends_on we no longer need the
  healthcheck on services, but instead have to use simple
  while-wait-loops in the commands of downstream services

Related machine-learning-exchange#256
Related machine-learning-exchange#259
Related 3c10fda
Related https://forums.docker.com/t/depends-on-version-3/29463

Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner mentioned this pull request Dec 2, 2021
mlx-bot pushed a commit that referenced this pull request Dec 3, 2021
* Since we have /catalog/upload_from_url API now (#259), we
  no longer need to keep a copy of the catalog_upload.json
  file under quickstart
* Since all assets get published and featured automatically
  with catalog upload (#256), there is no longer a need for
  the init_catalog.sh script either
* Since the MLX API also creates the Pipelines table (3c10fda)
  we no longer need to mount the init_db.sql to the mysql
  service
* Since the Docker Compose File v3+ spec no longer supports
  condition as an option of depends_on we no longer need the
  healthcheck on services, but instead have to use simple
  while-wait-loops in the commands of downstream services

Related #256
Related #259
Related 3c10fda
Related https://forums.docker.com/t/depends-on-version-3/29463

Signed-off-by: Christian Kadner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm RCOS Potential work items for RCOS student interns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow catalog upload via URL instead of catalog_upload.json file
3 participants