[mlx-ui] handle .js in static handler #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhwang
force-pushed
the
mlx-ui-fix-static-handler
branch
from
1c7a614 to
ce23e3f
Compare
don't modify the request url in static handler if it's js file. we need dashboard_lib.bundle.js if mlx servers on / prefix Signed-off-by: Yihong Wang <[email protected]>
yhwang
force-pushed
the
mlx-ui-fix-static-handler
branch
from
ce23e3f to
b859fbb
Compare
|
thanks @yhwang |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tomcli, yhwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ckadner
reviewed
Oct 29, 2021
ckadner
reviewed
Oct 29, 2021
| ['iframe', 'iframe-run'].forEach((id) => { | ||
| const element = document.getElementById(id) as HTMLIFrameElement; | ||
| if (element) { | ||
| // TODO: get namespace from user info, use fixed value: mlx for now |
There was a problem hiding this comment.
Do we have an issue already to track getting the namespace from the user info?
There was a problem hiding this comment.
nope, I didn't create one when writing down that todo.....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't modify the request url in static handler
if it's js file. we need dashboard_lib.bundle.js
if mlx servers on / prefix
Signed-off-by: Yihong Wang [email protected]