Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Get the namespace from the user info for run iFrame #253

Open
ckadner opened this issue Oct 29, 2021 · 3 comments
Open

[UI] Get the namespace from the user info for run iFrame #253

ckadner opened this issue Oct 29, 2021 · 3 comments
Labels
UI User Interface

Comments

@ckadner
Copy link
Member

ckadner commented Oct 29, 2021 •
edited
Loading

When we support multiple users in the future, beyond admin and unauthenticated users, we will need to get the namespace from the user info for the Pipeline Run and View Experiments iFrame

mlx/dashboard/origin-mlx/src/App.tsx

Lines 69 to 70 in bbcf7e1

// TODO: get namespace from user info, use fixed value: mlx for now
element.contentWindow.postMessage({type: 'namespace-selected', value: 'mlx'}, origin);

Originally posted by @ckadner in #252 (comment)
@ckadner
Copy link
Member Author

ckadner commented Oct 29, 2021

FYI @yhwang @Tomcli

ckadner referenced this issue Oct 29, 2021
@yhwang
[mlx-ui] handle .js in static handler (#252)
bbcf7e1 
don't modify the request url in static handler
if it's js file. we need dashboard_lib.bundle.js
if mlx servers on / prefix

Signed-off-by: Yihong Wang <[email protected]>
@ckadner ckadner added the UI User Interface label Oct 29, 2021
@ckadner ckadner changed the title [UI] Getting the namespace from the user info for run iFrame [UI] Get the namespace from the user info for run iFrame Oct 29, 2021
@yhwang
Copy link
Member

yhwang commented Oct 29, 2021

and also the experiment view iFrame :-)

@yhwang
Copy link
Member

yhwang commented Oct 29, 2021

and maybe figure out if we can use just one iFrame for both of them. my guess is yes

@ckadner ckadner mentioned this issue Nov 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI User Interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yhwang @ckadner