Fix a false JSError reported by Phantomas #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macbre
reviewed
Jul 31, 2023
Comment on lines
+13
to
+18
| // thoses ones should not fail (as in a real browser) | ||
| document.getElementsByTagName(undefined); | ||
| document.getElementById(undefined); | ||
| document.getElementsByClassName(undefined); | ||
| document.querySelector(undefined); | ||
| </script> |
macbre
approved these changes
Jul 31, 2023
macbre
approved these changes
Jul 31, 2023
gmetais
added a commit
to gmetais/phantomas
that referenced
this pull request
Aug 13, 2023
Co-authored-by: Maciej Brencz <[email protected]>
macbre
added a commit
that referenced
this pull request
Sep 18, 2023
* Build(deps): bump coverallsapp/github-action from 2.2.0 to 2.2.1 (#171) Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@v2.2.0...v2.2.1) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): bump puppeteer from 20.8.1 to 20.8.3 (#172) Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 20.8.1 to 20.8.3. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json) - [Commits](puppeteer/puppeteer@puppeteer-v20.8.1...puppeteer-v20.8.3) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Build(deps): bump puppeteer from 20.8.3 to 20.9.0 (#173) Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 20.8.3 to 20.9.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json) - [Commits](puppeteer/puppeteer@puppeteer-v20.8.3...puppeteer-v20.9.0) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add AVIF as an image type (#1299) Co-authored-by: Maciej Brencz <[email protected]> * Fix a false JSError reported by Phantomas (#1296) Co-authored-by: Maciej Brencz <[email protected]> * v2.9.0 * (deps) bump puppeteer to v21.0.2 * Update from upstream Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update from upstream * Introduce a new analyze-images module with a few rules * Linter / prettifier / make-docs * Update package.json + package-lock.json * Fix package-lock.json --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Maciej Brencz <[email protected]> Co-authored-by: macbre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I noticed that Phantomas was (rarely) reporting a JS error that doesn't exist in real browsers.
If the
document.getElementsByTagName()function is called with an incorrect value (such asundefinedornull), browsers fail silently while Phantomas adds the following error to the JSErrors metric:Cannot read properties of undefined (reading 'toLowerCase').Here is a fix. No urgency in publishing that fix in a new version.