Fix a false JSError reported by Phantomas (#1296)

Co-authored-by: Maciej Brencz <[email protected]>
macbre · Jul 31, 2023 · c4b4bb2 · c4b4bb2
1 parent f5a7e15
commit c4b4bb2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/modules/domQueries/scope.js b/modules/domQueries/scope.js
@@ -58,7 +58,7 @@
     var context = phantomas.getDOMPath(this);
 
     // querying by BODY and body is the same (issue #419)
-    tagName = tagName.toLowerCase();
+    if (tagName) tagName = tagName.toLowerCase();
 
     phantomas.incrMetric("DOMqueriesByTagName");
     phantomas.addOffender("DOMqueriesByTagName", {

diff --git a/test/webroot/js-errors.html b/test/webroot/js-errors.html
@@ -9,4 +9,11 @@
         // and this one too, but the execution will never reach this linen
         window.Foo('test');
 	</script>
+	<script>
+        // thoses ones should not fail (as in a real browser)
+        document.getElementsByTagName(undefined);
+        document.getElementById(undefined);
+        document.getElementsByClassName(undefined);
+        document.querySelector(undefined);
+	</script>
 </body>