-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change coordinator to query and add m3query
service
#817
Changes from 8 commits
65f353b
5cf2c0b
2a5289a
2b6fd6a
c68df89
a27f3f0
f50e498
a3758fa
529807b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,7 @@ LABEL maintainer="The M3DB Authors <[email protected]>" | |
EXPOSE 7201/tcp 7203/tcp | ||
|
||
COPY --from=builder /go/src/github.com/m3db/m3db/bin/m3coordinator /bin/ | ||
COPY --from=builder /go/src/github.com/m3db/m3db/src/coordinator/config/m3coordinator-local-etcd.yml /etc/m3coordinator/m3coordinator.yml | ||
COPY --from=builder /go/src/github.com/m3db/m3db/src/query/config/m3coordinator-local-etcd.yml /etc/m3coordinator/m3coordinator.yml | ||
|
||
ENTRYPOINT [ "/bin/m3coordinator" ] | ||
CMD [ "-f", "/etc/m3coordinator/m3coordinator.yml" ] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ import ( | |
_ "net/http/pprof" // pprof: for debug listen server if configured | ||
"os" | ||
|
||
"github.com/m3db/m3db/src/coordinator/services/m3coordinator/server" | ||
"github.com/m3db/m3db/src/query/services/m3coordinator/server" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The plan is to follow up and move the package being imported here to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes- and register the placement handlers there and remove them from |
||
) | ||
|
||
var ( | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
// Copyright (c) 2018 Uber Technologies, Inc. | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a copy | ||
// of this software and associated documentation files (the "Software"), to deal | ||
// in the Software without restriction, including without limitation the rights | ||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
// copies of the Software, and to permit persons to whom the Software is | ||
// furnished to do so, subject to the following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be included in | ||
// all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
// THE SOFTWARE. | ||
|
||
package main | ||
|
||
import ( | ||
"flag" | ||
_ "net/http/pprof" // pprof: for debug listen server if configured | ||
"os" | ||
|
||
"github.com/m3db/m3db/src/query/services/m3coordinator/server" | ||
) | ||
|
||
var ( | ||
configFile = flag.String("f", "", "configuration file") | ||
) | ||
|
||
func main() { | ||
flag.Parse() | ||
|
||
if len(*configFile) == 0 { | ||
flag.Usage() | ||
os.Exit(1) | ||
} | ||
|
||
server.Run(server.RunOptions{ | ||
ConfigFile: *configFile, | ||
}) | ||
} |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm do you want to chance the directory name here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah maybe we should move these config files outside of
src
completely? It's weird we have some YAML files in these dirs floating around.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess we should figure out if we want to have an m3coordinator and an m3query dockerfile? we can discuss today once everyone is in