Change coordinator to query and add m3query service
#817
Conversation
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
==========================================
- Coverage 78.03% 77.92% -0.12%
==========================================
Files 368 368
Lines 31798 31798
==========================================
- Hits 24815 24779 -36
- Misses 5309 5337 +28
- Partials 1674 1682 +8
Continue to review full report at Codecov.
|
benraskin92
changed the title
m3query service
| @@ -21,7 +21,7 @@ LABEL maintainer="The M3DB Authors <[email protected]>" | |||
| EXPOSE 7201/tcp 7203/tcp | |||
|
|
|||
| COPY --from=builder /go/src/github.com/m3db/m3db/bin/m3coordinator /bin/ | |||
| COPY --from=builder /go/src/github.com/m3db/m3db/src/coordinator/config/m3coordinator-local-etcd.yml /etc/m3coordinator/m3coordinator.yml | |||
| COPY --from=builder /go/src/github.com/m3db/m3db/src/query/config/m3coordinator-local-etcd.yml /etc/m3coordinator/m3coordinator.yml | |||
There was a problem hiding this comment.
hm do you want to chance the directory name here too
There was a problem hiding this comment.
Yeah maybe we should move these config files outside of src completely? It's weird we have some YAML files in these dirs floating around.
There was a problem hiding this comment.
i guess we should figure out if we want to have an m3coordinator and an m3query dockerfile? we can discuss today once everyone is in
scripts/process-cover.sh
Outdated
| @@ -12,7 +12,7 @@ TARGETS=("dbnode" "coordinator" "m3ninx") | |||
| target_patterns() { | |||
| case $1 in | |||
| 'dbnode') echo "^mode|github.com/m3db/m3db/src/dbnode|github.com/m3db/m3db/src/cmd/services/m3dbnode";; | |||
| 'coordinator') echo "^mode|github.com/m3db/m3db/src/coordinator|github.com/m3db/m3db/src/cmd/services/m3coordinator";; | |||
| 'coordinator') echo "^mode|github.com/m3db/m3db/src/query|github.com/m3db/m3db/src/cmd/services/m3coordinator";; | |||
There was a problem hiding this comment.
hmm maybe rename this to 'query' too
There was a problem hiding this comment.
similarly for the .codecov.yml file and -F flags in the makefile
| @@ -25,7 +25,7 @@ import ( | |||
| _ "net/http/pprof" // pprof: for debug listen server if configured | |||
| "os" | |||
|
|
|||
| "github.com/m3db/m3db/src/coordinator/services/m3coordinator/server" | |||
| "github.com/m3db/m3db/src/query/services/m3coordinator/server" | |||
There was a problem hiding this comment.
The plan is to follow up and move the package being imported here to src/coordinator/server/... yeah?
There was a problem hiding this comment.
Yes- and register the placement handlers there and remove them from src/github.com/m3db/m3db/src/query/services/m3coordinator/server (and also rename this to .../services/m3query/...
No description provided.