Make proto-gen targets not rely on GOPATH #4136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateek
approved these changes
Mar 8, 2023
Similar to #4135 Since m3 is now a go.mod project, it's no longer necessary to be checked out under GOPATH. This PR makes our code generation reflect that fact. I've switched to use of relative paths in generate.go, which as I understand it is the preferred way of doing things generally. Our proto-gen script now takes in an actual path to proto files vs a logical path. It infers the logical repo path from the actual path. Fixes #4134
andrewmains12
force-pushed
the
amains/gen_fix.all
branch
from
6e9b2d2 to
fdce009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #4135
Since m3 is now a go.mod project, it's no longer necessary to be checked out under GOPATH.
This PR makes our code generation reflect that fact. I've switched to use of relative paths in generate.go, which as I understand
it is the preferred way of doing things generally.
Our proto-gen script now takes in an actual path to proto files vs a logical path. It infers the logical repo path from the actual path.
Fixes #4134