Make code generation not require a GOPATH set (mocks, thrift) #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmains12
force-pushed
the
amains/gen_fix.review
branch
from
7456593 to
ed85d80
Compare
… protobuf) Since m3 is now a go.mod project, it's no longer necessary to be checked out under GOPATH. This PR makes our code generation reflect that fact. I've switched to use of relative paths in generate.go, which as I understand it is the preferred way of doing things generally. Note: I haven't yet fixed the protobuf generation--there are a couple more kinks to work out there. This PR handles thrift and mocks.
andrewmains12
force-pushed
the
amains/gen_fix.review
branch
from
ed85d80 to
869efb4
Compare
andrewmains12
changed the title
shaan420
approved these changes
Aug 10, 2022
andrewmains12
added a commit
that referenced
this pull request
Aug 10, 2022
Similar to #4135 Since m3 is now a go.mod project, it's no longer necessary to be checked out under GOPATH. This PR makes our code generation reflect that fact. I've switched to use of relative paths in generate.go, which as I understand it is the preferred way of doing things generally. Our proto-gen script now takes in an actual path to proto files vs a logical path. It infers the logical repo path from the actual path. Fixes #4134
safa-topal
pushed a commit
to aiven/m3
that referenced
this pull request
Jan 12, 2023
… protobuf) (m3db#4135) Since m3 is now a go.mod project, it's no longer necessary to be checked out under GOPATH. This PR makes our code generation reflect that fact. I've switched to use of relative paths in generate.go, which as I understand it is the preferred way of doing things generally. Note: I haven't yet fixed the protobuf generation--there are a couple more kinks to work out there. This PR handles thrift and mocks.
andrewmains12
added a commit
that referenced
this pull request
Mar 9, 2023
Similar to #4135 Since m3 is now a go.mod project, it's no longer necessary to be checked out under GOPATH. This PR makes our code generation reflect that fact. I've switched to use of relative paths in generate.go, which as I understand it is the preferred way of doing things generally. Our proto-gen script now takes in an actual path to proto files vs a logical path. It infers the logical repo path from the actual path. Fixes #4134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since m3 is now a go.mod project, it's no longer necessary to be checked out under GOPATH.
This PR makes our code generation reflect that fact. I've switched to use of relative paths in generate.go, which as I understand
it is the preferred way of doing things generally.
Note: I haven't yet fixed the protobuf generation--there are a couple more kinks to work out there. This PR handles thrift and mocks.
Fixes #4134