[dbnode] Add config option to set repair strategy (default/full_sweep) and concurrency #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3573 +/- ##
======================================
Coverage 55.8% 55.8%
======================================
Files 550 550
Lines 62174 62174
======================================
Hits 34699 34699
Misses 24379 24379
Partials 3096 3096
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
arnikola
reviewed
Jun 25, 2021
| @@ -681,6 +695,13 @@ func (r *dbRepairer) Repair() error { | |||
| leastRecentlyRepairedBlockStartLastRepairTime xtime.UnixNano | |||
| ) | |||
| repairRange.IterateBackward(blockSize, func(blockStart xtime.UnixNano) bool { | |||
| // Update metrics around progress of repair. | |||
| blockStartUnixSeconds := blockStart.ToTime().Unix() | |||
There was a problem hiding this comment.
nit: blockStart.Seconds()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the ability to set repair strategy to full_sweep to sweep from beginning of time to end without restarting when encountering blocks that need repair.
This mode may be more ideal in clusters that have never had repair enabled to ensure that historical data gets repaired at least once on a full sweep before switching back to the default strategy.
It also adds the ability to set the repair concurrency from config.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: