Avoid divide by zero when compared blocks is zero

m3db · Jun 28, 2021 · 1f1e8ef · 1f1e8ef
1 parent 2660ca8
commit 1f1e8ef
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/dbnode/storage/repair/types.go b/src/dbnode/storage/repair/types.go
@@ -298,6 +298,10 @@ func (r PeerMetadataComparisonResults) Aggregate() AggregatePeerMetadataComparis
 		result.ComparedMissingBlocks += elem.ComparedMissingBlocks
 		result.ComparedExtraBlocks += elem.ComparedExtraBlocks
 	}
+	if result.ComparedBlocks > 0 {
+		// Do not divide by zero and end up with a struct that cannot be JSON serialized.
+		return result
+	}
 	result.ComparedDifferingPercent = float64(result.ComparedDifferingBlocks) / float64(result.ComparedBlocks)
 	return result
 }