Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lint] Add missing build tags to linter configuration #3480

Merged
merged 4 commits into from
May 7, 2021

Conversation

vpranckaitis
Copy link
Collaborator

What this PR does / why we need it:

Adds missing build tags to linter configuration. Without these, some of the *.go files (mostly integration tests) were not linted.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #3480 (d838a75) into master (d838a75) will not change coverage.
The diff coverage is n/a.

❗ Current head d838a75 differs from pull request most recent head 754d84b. Consider uploading reports for the commit 754d84b to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3480   +/-   ##
======================================
  Coverage    55.8%   55.8%           
======================================
  Files         548     548           
  Lines       61188   61188           
======================================
  Hits        34196   34196           
  Misses      23902   23902           
  Partials     3090    3090           
Flag Coverage Δ
aggregator 57.3% <0.0%> (ø)
cluster ∅ <0.0%> (∅)
collector 54.3% <0.0%> (ø)
dbnode 60.2% <0.0%> (ø)
m3em 46.4% <0.0%> (ø)
metrics 19.8% <0.0%> (ø)
msg 74.6% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d838a75...754d84b. Read the comment docs.

Copy link
Collaborator

@linasm linasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@vpranckaitis vpranckaitis enabled auto-merge (squash) May 7, 2021 09:30
@vpranckaitis vpranckaitis merged commit 6ea9541 into master May 7, 2021
@vpranckaitis vpranckaitis deleted the vilius/linter_build_tags branch May 7, 2021 09:43
soundvibe pushed a commit that referenced this pull request May 10, 2021
* master:
  [query] Add Graphite movingWindow() function (#3484)
  [lint] Add missing build tags to linter configuration (#3480)
  [query] Fix Graphite nil arg not interpreted as explicit nil (#3481)
  [query] Fix Graphite context time window expansions not being cumulative
  [readme] Remove coverage badge due to CodeCov not able to execute (#3476)
  [query] Fix using median with aggregateWithWildcards and support more aggregate functions (#3469)
  [matcher] [coordinator] Add RequireNamespaceWatchOnInit option (#3468)
  [buildkite] Remove codecov uploading from unit tests (#3475)
  [aggregator] Add integration test for aggregator placement changes (#3465)
  [tools] Use streaming reads in read_data_files (#3474)
  [tools] Close the reader in read_data_files (#3473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants