Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buildkite] Remove codecov uploading from unit tests #3475

Merged
merged 2 commits into from
May 6, 2021
Merged

Conversation

wesleyk
Copy link
Collaborator

@wesleyk wesleyk commented May 6, 2021

Temporarily disabling while codecov uploading is flaky

What this PR does / why we need it:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@wesleyk wesleyk enabled auto-merge (squash) May 6, 2021 13:54
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #3475 (6c4b901) into master (6c4b901) will not change coverage.
The diff coverage is n/a.

❗ Current head 6c4b901 differs from pull request most recent head aac485a. Consider uploading reports for the commit aac485a to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3475   +/-   ##
=======================================
  Coverage    72.4%    72.4%           
=======================================
  Files        1103     1103           
  Lines      102807   102807           
=======================================
  Hits        74440    74440           
  Misses      23263    23263           
  Partials     5104     5104           
Flag Coverage Δ
aggregator 77.1% <0.0%> (ø)
cluster 84.9% <0.0%> (ø)
collector 84.3% <0.0%> (ø)
dbnode 79.0% <0.0%> (ø)
m3em 74.4% <0.0%> (ø)
m3ninx 73.6% <0.0%> (ø)
metrics 19.7% <0.0%> (ø)
msg 74.6% <0.0%> (ø)
query 66.9% <0.0%> (ø)
x 79.9% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c4b901...aac485a. Read the comment docs.

@soundvibe soundvibe self-requested a review May 6, 2021 14:11
@wesleyk wesleyk merged commit df9bb93 into master May 6, 2021
@wesleyk wesleyk deleted the wesley-cov branch May 6, 2021 14:11
soundvibe added a commit that referenced this pull request May 10, 2021
* master:
  [query] Add Graphite movingWindow() function (#3484)
  [lint] Add missing build tags to linter configuration (#3480)
  [query] Fix Graphite nil arg not interpreted as explicit nil (#3481)
  [query] Fix Graphite context time window expansions not being cumulative
  [readme] Remove coverage badge due to CodeCov not able to execute (#3476)
  [query] Fix using median with aggregateWithWildcards and support more aggregate functions (#3469)
  [matcher] [coordinator] Add RequireNamespaceWatchOnInit option (#3468)
  [buildkite] Remove codecov uploading from unit tests (#3475)
  [aggregator] Add integration test for aggregator placement changes (#3465)
  [tools] Use streaming reads in read_data_files (#3474)
  [tools] Close the reader in read_data_files (#3473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants