Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dtest] Fix dtest docker compose config: env => environment #3421

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

vpranckaitis
Copy link
Collaborator

What this PR does / why we need it:

Fixes dtest docker compose config, renaming env to environment.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #3421 (0952775) into master (0952775) will not change coverage.
The diff coverage is n/a.

❗ Current head 0952775 differs from pull request most recent head 8aa6373. Consider uploading reports for the commit 8aa6373 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3421   +/-   ##
=======================================
  Coverage    72.4%    72.4%           
=======================================
  Files        1100     1100           
  Lines      102536   102536           
=======================================
  Hits        74266    74266           
  Misses      23164    23164           
  Partials     5106     5106           
Flag Coverage Δ
aggregator 76.8% <0.0%> (ø)
cluster 84.9% <0.0%> (ø)
collector 84.3% <0.0%> (ø)
dbnode 78.9% <0.0%> (ø)
m3em 74.4% <0.0%> (ø)
m3ninx 73.5% <0.0%> (ø)
metrics 19.8% <0.0%> (ø)
msg 74.4% <0.0%> (ø)
query 67.0% <0.0%> (ø)
x 80.5% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0952775...8aa6373. Read the comment docs.

@gediminasgu gediminasgu removed their assignment Apr 15, 2021
@vpranckaitis vpranckaitis enabled auto-merge (squash) April 15, 2021 14:28
@vpranckaitis vpranckaitis merged commit 95478bd into master Apr 15, 2021
@vpranckaitis vpranckaitis deleted the vilius/fix_dtest_docker_compose branch April 15, 2021 14:41
soundvibe added a commit that referenced this pull request Apr 16, 2021
* master:
  [dbnode] Set default values for BootstrapPeersConfiguration (#3420)
  [integration-tests] Use explicit version for quay.io/m3db/prometheus_remote_client_golang (#3422)
  [dtest] Fix dtest docker compose config: env => environment (#3421)
  Fix broken links to edit pages (#3419)
  [dbnode] Fix races in source_data_test.go (#3418)
  [coordinator] add more information to processed count metric (#3415)
  [dbnode] Avoid use of grow on demand worker pool for fetchTagged and aggregate (#3416)
  [docs] Fix m3aggregagtor typo (#3417)
  [x/log] Bump zap version and add logging encoder configuration (#3377)
  Do not use buffer channels if growOnDemand is true (#3414)
  [dbnode] Fix TestSeriesWriteReadParallel datapoints too far in past with -race flag (#3413)
  [docs] Update m3db operator docs with v0.13.0 features (#3397)
  [aggregator] Fix followerFlushManager metrics (#3411)
  [query] Restore optimization to skip initial fetch for timeShift and unary fns (#3408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants