[dbnode] Set default values for BootstrapPeersConfiguration

[vpranckaitis]

What this PR does / why we need it:

Fixes #3286: when only a subset of BootstrapPeersConfiguration parameters were supplied in config, others defaulted to 0 instead of default values mentioned in parameter description.

m3/src/cmd/services/m3dbnode/config/bootstrap.go

Lines 250 to 263 in 37e8c9b

	type BootstrapPeersConfiguration struct {
	// StreamShardConcurrency controls how many shards in parallel to stream
	// for in memory data being streamed between peers (most recent block).
	// Defaults to: numCPU.
	StreamShardConcurrency int `yaml:"streamShardConcurrency"`
	// StreamPersistShardConcurrency controls how many shards in parallel to stream
	// for historical data being streamed between peers (historical blocks).
	// Defaults to: numCPU / 2.
	StreamPersistShardConcurrency int `yaml:"streamPersistShardConcurrency"`
	// StreamPersistShardFlushConcurrency controls how many shards in parallel to flush
	// for historical data being streamed between peers (historical blocks).
	// Defaults to: 1.
	StreamPersistShardFlushConcurrency int `yaml:"streamPersistShardFlushConcurrency"`
	}

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

[vpranckaitis]

Default values are already being set in peers.NewOptions():

m3/src/dbnode/storage/bootstrap/bootstrapper/peers/options.go

Lines 88 to 101 in 37e8c9b

	func NewOptions() Options {
	return &options{
	resultOpts: result.NewOptions(),
	defaultShardConcurrency: DefaultShardConcurrency,
	shardPersistenceConcurrency: DefaultShardPersistenceConcurrency,
	shardPersistenceFlushConcurrency: DefaultShardPersistenceFlushConcurrency,
	indexSegmentConcurrency: fsbootstrapper.DefaultIndexSegmentConcurrency,
	persistenceMaxQueueSize: defaultPersistenceMaxQueueSize,
	// Use a zero pool, this should be overridden at config time.
	contextPool: context.NewPool(context.NewOptions().
	SetContextPoolOptions(pool.NewObjectPoolOptions().SetSize(0)).
	SetFinalizerPoolOptions(pool.NewObjectPoolOptions().SetSize(0))),
	}
	}

[codecov]

Codecov Report

Merging #3420 (92cc8c1) into master (92cc8c1) will not change coverage.
The diff coverage is n/a.

❗ Current head 92cc8c1 differs from pull request most recent head 05bd563. Consider uploading reports for the commit 05bd563 to get more accurate results

@@           Coverage Diff           @@
##           master    #3420   +/-   ##
=======================================
  Coverage    72.4%    72.4%           
=======================================
  Files        1100     1100           
  Lines      102602   102602           
=======================================
  Hits        74347    74347           
  Misses      23151    23151           
  Partials     5104     5104           

Flag	Coverage Δ
aggregator	76.9% <0.0%> (ø)
cluster	84.9% <0.0%> (ø)
collector	84.3% <0.0%> (ø)
dbnode	79.0% <0.0%> (ø)
m3em	74.4% <0.0%> (ø)
m3ninx	73.5% <0.0%> (ø)
metrics	19.8% <0.0%> (ø)
msg	74.4% <0.0%> (ø)
query	67.0% <0.0%> (ø)
x	80.5% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92cc8c1...05bd563. Read the comment docs.

[linasm]

LGTM