[DOCS] Add warning to changing blocksize #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrisChinchilla <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3096 +/- ##
========================================
+ Coverage 65.5% 72.3% +6.7%
========================================
Files 1080 1083 +3
Lines 99058 99893 +835
========================================
+ Hits 64906 72231 +7325
+ Misses 29367 22631 -6736
- Partials 4785 5031 +246
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
wesleyk
reviewed
Jan 18, 2021
| There is currently no atomic namespace modification endpoint. Instead, you will need to delete a namespace and then add it back again with the same name, but modified settings. Review the individual namespace settings above to determine whether or not a given setting is safe to modify. | ||
|
|
||
| {{% notice warning %}} | ||
| For example, it is never safe to modify the blockSize of a namespace. |
There was a problem hiding this comment.
maybe we should phrase this as a list of warnings / unsafe items, with this being the first?
There was a problem hiding this comment.
@wesleyk Good idea, but I think I'll do that when we get to the rewrite, which is kind of in progress right now anyway
wesleyk
approved these changes
Jan 18, 2021
soundvibe
pushed a commit
that referenced
this pull request
Jan 22, 2021
* master: [DOCS] Update to cluster docs (#3084) [dbnode][coordinator] Ensure docs limit is propagated for search and aggregate RPCs (#3108) [query] Take bounds into account for list endpoints (#3110) Add warning to changing blocksize (#3096) Add support for dynamic query limit overriding (#3090) [tests] test setups exported to allow us to use it from other packages (#3042) [query] Implemented Graphite's pow function (#3048) [dbnode] Direct conversion of encoded tags to doc.Metadata (#3087) [tests] Skip flaky TestWatchNoLeader (#3106) [dbnode] Faster search of tag bytes in convert.FromSeriesIDAndTags (#3075) Replace bytes.Compare() == 0 with bytes.Equal() (#3101) Capture seekerMgr instead Rlock (#3104) [m3db] Check bloom filter before stream request allocation (#3103)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #2789 (comment) this PR adds a warning to highlight users shouldn't change blocksize.