[dbnode] implement deletion method in namespace kvadmin service #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #2861 +/- ##
=======================================
Coverage 71.8% 71.9%
=======================================
Files 1100 1100
Lines 100461 99973 -488
=======================================
- Hits 72220 71892 -328
+ Misses 23285 23114 -171
- Partials 4956 4967 +11
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vdarulis
approved these changes
Nov 10, 2020
Comment on lines
+27
to
+28
| uuid "github.com/satori/go.uuid" | ||
|
|
|
|
||
| nsMap, err := namespace.FromProto(*currentRegistry) | ||
| if err != nil { | ||
| return xerrors.Wrap(err, "failed to unmarhal namespace registry") |
| "testing" | ||
|
|
||
| "github.com/golang/mock/gomock" | ||
|
|
There was a problem hiding this comment.
same, group non-stdlib imports
…com/m3db/m3 into mmiksys/kv-admin-namespace-deletion
soundvibe
added a commit
that referenced
this pull request
Nov 11, 2020
* master: (28 commits) [dbnode] Add claims for index segments volume index (#2846) [dbnode] Remove namespaces from example config and integration tests (#2866) [dbnode] Resurrect flaky test skip (#2868) [aggregator] Fix checkCampaignStateLoop (#2867) [dbnode] implement deletion method in namespace kvadmin service (#2861) Replace closer with resource package (#2864) Add coding style guide (#2831) Add GOVERNANCE.md to describe governance (#2830) Add COMPATIBILITY.md to describe version compatibility (#2829) Refactor etcd config as discovery section with convenience types (#2843) Refactor x/lockfile into dbnode/server (#2862) [lint] Disable nlreturn linter (#2865) [m3cluster] Expose placement algorithm in placement service (#2858) [etcd] Set reasonable cluster connection/sync settings by default (#2860) [dbnode] Use bits.LeadingZeros64 to improve encoder performance (#2857) Cleanup m3nsch leftovers (#2856) Update ci-scripts to correct coverage tracking (#2854) [aggregator] Process campaign state without waiting for first campaign check interval (#2855) Bump go to 1.14 (#2853) [query] Remove single series error from M3 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Functionality added in this PR will enable deleting namespaces using
kvadmin.NamespaceMetadataAdminServicelibrary. Previously, the service supported functionality for namespace retrieval, creation, schema updates etc. but the namespaces deletion part missing.Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: