Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci-scripts to correct coverage tracking #2854

Merged
merged 5 commits into from
Nov 8, 2020
Merged

Conversation

vdarulis
Copy link
Collaborator

@vdarulis vdarulis commented Nov 8, 2020

What this PR does / why we need it:

Fixes flaky coverage calculations

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@codecov
Copy link

codecov bot commented Nov 8, 2020

Codecov Report

Merging #2854 (b47ad46) into master (55e6e44) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2854     +/-   ##
========================================
- Coverage    72.1%   72.1%   -0.1%     
========================================
  Files        1099    1099             
  Lines       99883   99807     -76     
========================================
- Hits        72094   71965    -129     
- Misses      22863   22904     +41     
- Partials     4926    4938     +12     
Flag Coverage Δ
aggregator 75.8% <ø> (-0.4%) ⬇️
cluster 84.9% <ø> (ø)
collector 84.3% <ø> (ø)
dbnode 79.3% <ø> (-0.1%) ⬇️
m3em 74.4% <ø> (ø)
m3ninx 73.1% <ø> (+<0.1%) ⬆️
metrics 17.2% <ø> (ø)
msg 74.2% <ø> (+0.1%) ⬆️
query 68.9% <ø> (ø)
x 80.2% <ø> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e6e44...e9117ae. Read the comment docs.

@vdarulis vdarulis requested a review from abliqo November 8, 2020 17:52
@vdarulis vdarulis marked this pull request as ready for review November 8, 2020 17:53
@vdarulis vdarulis merged commit fa680ea into master Nov 8, 2020
@vdarulis vdarulis deleted the v/covermode branch November 8, 2020 18:15
soundvibe added a commit that referenced this pull request Nov 11, 2020
* master: (28 commits)
  [dbnode] Add claims for index segments volume index (#2846)
  [dbnode] Remove namespaces from example config and integration tests (#2866)
  [dbnode] Resurrect flaky test skip (#2868)
  [aggregator] Fix checkCampaignStateLoop (#2867)
  [dbnode] implement deletion method in namespace kvadmin service (#2861)
  Replace closer with resource package (#2864)
  Add coding style guide (#2831)
  Add GOVERNANCE.md to describe governance (#2830)
  Add COMPATIBILITY.md to describe version compatibility (#2829)
  Refactor etcd config as discovery section with convenience types (#2843)
  Refactor x/lockfile into dbnode/server (#2862)
  [lint] Disable nlreturn linter (#2865)
  [m3cluster] Expose placement algorithm in placement service (#2858)
  [etcd] Set reasonable cluster connection/sync settings by default (#2860)
  [dbnode] Use bits.LeadingZeros64 to improve encoder performance (#2857)
  Cleanup m3nsch leftovers (#2856)
  Update ci-scripts to correct coverage tracking (#2854)
  [aggregator] Process campaign state without waiting for first campaign check interval (#2855)
  Bump go to 1.14 (#2853)
  [query] Remove single series error from M3
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants