Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate API key during org Setup #51

Merged
merged 12 commits into from
Oct 31, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Oct 28, 2024

This change builds on #50 and adds the APIkeys logic to Org.Setup. This change also modifies orgadm to report the org API key for a given org.

This change also includes a bug fix to the condition expression added in #48

This change also adds a flag to orgadm to allow an org's service account to update the tables schemas. This is only needed by the mlab org.


This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Oct 28, 2024

Pull Request Test Coverage Report for Build 11601057306

Details

  • 33 of 33 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 98.904%

Totals Coverage Status
Change from base Build 11584606813: 0.02%
Covered Lines: 1173
Relevant Lines: 1186

💛 - Coveralls

Base automatically changed from sandbox-soltesz-orgadm-apikey to main October 30, 2024 00:20
@stephen-soltesz stephen-soltesz marked this pull request as ready for review October 30, 2024 19:33
@stephen-soltesz stephen-soltesz marked this pull request as draft October 30, 2024 19:34
@stephen-soltesz stephen-soltesz marked this pull request as ready for review October 30, 2024 20:25
Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit 0b27b6e into main Oct 31, 2024
8 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-orgadm-apikey-2 branch October 31, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants