Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downloader to gcs read condition #48

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Oct 7, 2024

This change adds an additional condition to the autojoin service account to allow reads from the downloader bucket. This is necessary for the uuid-annotator to load Maxmind data.


This change is Reviewable

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11223838824

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.825%

Totals Coverage Status
Change from base Build 10814726045: 0.0%
Covered Lines: 1093
Relevant Lines: 1106

💛 - Coveralls

@stephen-soltesz
Copy link
Contributor Author

I've applied this change the mlab and rnp service accounts.

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit dd47e34 into main Oct 8, 2024
8 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-fix-gcs-condition branch October 8, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants