Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid allowing incompatible version of maison to coexist with autoimport #261

Closed
wants to merge 1 commit into from

Conversation

wbbradley
Copy link
Contributor

A recent major version bump of maison is causing autoimport to fail at runtime because it claims to support maison>1.4.0.

Checklist

  • Add test cases to all the changes you introduce
  • Update the documentation for the changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10933727782

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.808%

Totals Coverage Status
Change from base Build 9895668044: 0.0%
Covered Lines: 320
Relevant Lines: 334

💛 - Coveralls

@spazm
Copy link

spazm commented Sep 20, 2024

Including this example of the error message displayed when maison 2.0.0 is installed.
Hoping this helps surface the details for anyone else who runs into this problem before the fix is pushed to pypy. See also #258 and #260

% autoimport
Traceback (most recent call last):
  File "/usr/local/bin/autoimport", line 5, in <module>
    from autoimport.entrypoints.cli import cli
  File "/lib/python3.12/site-packages/autoimport/entrypoints/cli.py", line 12, in <module>
    from maison.config import ProjectConfig
ImportError: cannot import name 'ProjectConfig' from 'maison.config' (/lib/python3.12/site-packages/maison/config.py)

@lyz-code
Copy link
Owner

lyz-code commented Oct 1, 2024

Closing as duplicate of #260

@lyz-code lyz-code closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants