Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support maison 2.0.0 #258

Open
daroczig opened this issue Aug 25, 2024 · 3 comments · May be fixed by #259
Open

Support maison 2.0.0 #258

daroczig opened this issue Aug 25, 2024 · 3 comments · May be fixed by #259
Labels
bug Something isn't working

Comments

@daroczig
Copy link

daroczig commented Aug 25, 2024

Description

It seems that the new release of maison is breaking autoimport.

As per https://github.com/dbatten5/maison/releases:

  • Renaming ProjectConfig to UserConfig

Steps to reproduce

$ autoimport --version
Traceback (most recent call last):
  File "../bin/autoimport", line 5, in <module>
    from autoimport.entrypoints.cli import cli
  File "../lib/python3.12/site-packages/autoimport/entrypoints/cli.py", line 12, in <module>
    from maison.config import ProjectConfig
ImportError: cannot import name 'ProjectConfig' from 'maison.config' (../lib/python3.12/site-packages/maison/config.py)

Current behavior

Desired behavior

No error, autoimport runs :)

Environment

autoimport==1.6.0
@daroczig daroczig added the bug Something isn't working label Aug 25, 2024
cjwatson added a commit to cjwatson/autoimport that referenced this issue Aug 26, 2024
@cjwatson cjwatson linked a pull request Aug 26, 2024 that will close this issue
@ErikBjare
Copy link
Contributor

Just bumped into this too while installing on a new system.

# I installed with pipx
pipx install autoimport

autoimport
# fails with: 
#    ImportError: cannot import name 'ProjectConfig' from 'maison.config' (/home/erb/.local/share/pipx/venvs/autoimport/lib/python3.12/site-packages/maison/config.py)

# fix
pipx inject autoimport 'maison<2' --force

autoimport
# works!

jasha-hrp added a commit to Jasha10/autoimport that referenced this issue Sep 17, 2024
@wbbradley
Copy link
Contributor

I didn't see the prior PR but I've opened another one that address rebuilding the pdm lockfile and adds an entry to the changelog. Feel free to close it as a dupe, or whatever. #261

@lyz-code
Copy link
Owner

lyz-code commented Oct 1, 2024

This has been patched by @zhou13 by pinning maison <2.0.0 and released under 1.6.1. I'll rename the issue to track the support of > 2.0.0.

If you're interested in fixing this issue @cjwatson has started this work here

@lyz-code lyz-code changed the title maison 2.0.0 Support maison 2.0.0 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants