Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus sink #119

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Add Prometheus sink #119

merged 3 commits into from
Jan 18, 2022

Conversation

golfdish
Copy link

@golfdish golfdish commented Jan 18, 2022

Merging into new branch promsink (off of [email protected]) for development release.

promauto is cautioned against because panics can happen at runtime if metric registration fails, but since creation/registration is abstracted behind the stats library, this is unavoidable anyway.

@golfdish golfdish requested review from lorenmh and njo January 18, 2022 21:25
prometheus_sink.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lorenmh lorenmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@golfdish golfdish merged commit f5f703c into promsink Jan 18, 2022
@golfdish golfdish deleted the golfdish/add-prom-sink branch January 18, 2022 21:59
@zirain
Copy link

zirain commented Jul 6, 2022

@lorenmh @golfdish what's current status of prom sink? will it be merged to master? if so, when will it happen?

zirain pushed a commit to zirain/gostats that referenced this pull request Jul 6, 2022
* Add Prometheus sink

* lint

* listen on :9090
@golfdish
Copy link
Author

golfdish commented Jul 6, 2022

Loren no longer works at Lyft. You may want to ask @njo or @kirtia1 about this, I've since paged out my context for it.

zirain pushed a commit to zirain/gostats that referenced this pull request Jul 30, 2024
* Add Prometheus sink

* lint

* listen on :9090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants