Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving away from promStatsdExporterContainer #3369

Closed
arkodg opened this issue May 10, 2024 · 8 comments · Fixed by #4272
Closed

Consider moving away from promStatsdExporterContainer #3369

arkodg opened this issue May 10, 2024 · 8 comments · Fixed by #4272
Assignees
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented May 10, 2024

Description:

Describe the issue.

#2729 added support for enabling scraping prometheus metrics using a sidecar container based off prom/statsd-exporter:v0.18.0 .
Pulling this image is tricky for air gapped clusters and adds another configuration point for syncing an extra image into a private registry

Can this be avoided if ratelimit introduced a prom endpoint natively, tracked with envoyproxy/ratelimit#285

[optional Relevant Links:]

Any extra documentation required to understand the issue.

@arkodg arkodg added the triage label May 10, 2024
@arkodg
Copy link
Contributor Author

arkodg commented May 21, 2024

hey @shawnh2 interested in investigating the feasibility of this one ? There's a PR linked to the above issue, unsure what's missing to get it through the finish line
cc @zirain

@zirain
Copy link
Contributor

zirain commented May 22, 2024

I cannot recall all the details last time I tried(it's long ago), most likely because lyft/gostats#119 didn't merge to master.

@shawnh2
Copy link
Contributor

shawnh2 commented May 22, 2024

assign myself now, I will take a deeper look.

@shawnh2 shawnh2 self-assigned this May 22, 2024
@arkodg arkodg added this to the v1.1.0-rc1 milestone May 23, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Jun 22, 2024
@arkodg arkodg modified the milestones: v1.1.0-rc1, Backlog Jul 3, 2024
@github-actions github-actions bot removed the stale label Jul 3, 2024
@zirain zirain assigned zirain and shawnh2 and unassigned shawnh2 and zirain Jul 22, 2024
@zirain zirain assigned zirain and unassigned shawnh2 Jul 30, 2024
@zirain
Copy link
Contributor

zirain commented Jul 30, 2024

assign this to me

@zirain
Copy link
Contributor

zirain commented Jul 31, 2024

xref: envoyproxy/ratelimit#663

@zirain
Copy link
Contributor

zirain commented Sep 12, 2024

xref: envoyproxy/ratelimit#681

@arkodg
Copy link
Contributor Author

arkodg commented Sep 17, 2024

looks like the ratelimit PR got merged !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants