ratelimit support prometheus #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zirain <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2729 +/- ##
==========================================
+ Coverage 63.41% 63.53% +0.11%
==========================================
Files 123 123
Lines 20092 20169 +77
==========================================
+ Hits 12741 12814 +73
- Misses 6531 6533 +2
- Partials 820 822 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zirain <[email protected]>
arkodg
reviewed
Feb 29, 2024
|
/retest |
arkodg
previously approved these changes
Mar 1, 2024
Xunzhuo
previously approved these changes
Mar 1, 2024
Signed-off-by: zirain <[email protected]>
zhaohuabing
reviewed
Mar 1, 2024
|
|
||
| type RateLimitMetricsPrometheusProvider struct { | ||
| // Disable the Prometheus endpoint. | ||
| Disable bool `json:"disable,omitempty"` |
There was a problem hiding this comment.
Does this need to be there level of nesting? Can it be simplified?
arkodg
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, envoy-gateway controller and proxy support metric in prometheus, this patch will make ratelimit as same as the other components.