feat: Authentication can be optionally disabled #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 66.22% 66.24% +0.01%
==========================================
Files 367 367
Lines 5860 5866 +6
Branches 893 894 +1
==========================================
+ Hits 3881 3886 +5
- Misses 1979 1980 +1
Continue to review full report at Codecov.
|
20 tasks
schottra
reviewed
Aug 20, 2020
env.js
Outdated
| @@ -39,6 +41,7 @@ module.exports = { | |||
| BASE_URL, | |||
| CORS_PROXY_PREFIX, | |||
| NODE_ENV, | |||
| STATUS_URL | |||
| STATUS_URL, | |||
There was a problem hiding this comment.
Two small things:
- These are sorted alphabetically, would prefer if you can keep that.
- It's not documented, but the way this object works is that items in
processEnvwill be sent to the client, and items outside of it are available on the server. I think this new variable should be in both places, so can you add it at both levels of the object?
schottra
reviewed
Aug 21, 2020
added 2 commits
August 24, 2020 09:59
schottra
approved these changes
Aug 24, 2020
kumare3
changed the title
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Aug 24, 2020
# [0.9.0](http://github.com/lyft/flyteconsole/compare/v0.8.1...v0.9.0) (2020-08-24) ### Features * Authentication can be optionally disabled ([#89](http://github.com/lyft/flyteconsole/issues/89)) ([d92a127](http://github.com/lyft/flyteconsole/commit/d92a1277af27a31863103eeda231d71b4e037151))
|
🎉 This PR is included in version 0.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
FlyteConsole enables authentication by default. This has a weird side-effect in Sandbox, where the console enables secure cookies, even if we actually do not have authN. in this situation, Chrome does not allow CORS with a wild card of
*. This PR allows disabling authN and which should allow working with CORsType
Are all requirements met?
Complete description
Disable credentials in case when authn is not used / required. This will allow CORs wildcard. Particularly helpful in sandbox testing.
Tracking Issue
flyteorg/flyte#416
Follow-up issue
NA