Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Confirmation Buttons Overflow on Execution Table #368

Merged
merged 1 commit into from
Apr 9, 2022
Merged

Fix Confirmation Buttons Overflow on Execution Table #368

merged 1 commit into from
Apr 9, 2022

Conversation

eugenejahn
Copy link
Contributor

@eugenejahn eugenejahn commented Apr 9, 2022 •
edited
Loading

In the execution table, the cancel button is overflowing, and half of the text can't be seen. Also, the duration data is not rendered.

what it looks like now.
image

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added back the duration data to render in the row
Fixed the width for the Confirmation Buttons. Use % for width, so it won't overflow

Tracking Issue

fixes https://github.com/flyteorg/flyteconsole/issues/367

Follow-up issue

@welcome
Copy link

welcome bot commented Apr 9, 2022

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@anrusina anrusina requested review from a team, ursucarina, anrusina and jsonporter and removed request for a team April 9, 2022 04:16
anrusina
anrusina previously approved these changes Apr 9, 2022
View reviewed changes
Copy link
Contributor

@anrusina anrusina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot for contributing! 🎉
I did a smoke test and it's definitely looks better now :)
Can you please sign off your PR, it is usually needed for open source contributions. Afterwards I would be able to merge in the changes.
To sign it -> run git rebase HEAD~1 --signoff on your branch and then force push it to this PR.

@codecov
Copy link

codecov bot commented Apr 9, 2022 •
edited
Loading

Codecov Report

Merging #368 (8439351) into master (7d2d252) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   66.00%   66.00%           
=======================================
  Files         402      402           
  Lines        8964     8964           
  Branches     1580     1580           
=======================================
  Hits         5917     5917           
  Misses       3047     3047
Impacted Files Coverage Δ
...Executions/Tables/WorkflowExecutionTable/styles.ts 100.00% <ø> (ø)
...es/WorkflowExecutionTable/WorkflowExecutionRow.tsx 66.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b1971a...8439351. Read the comment docs.

@eugenejahn eugenejahn force-pushed the bug-fixed/execution-row-confirmation-button-overflow branch from a34dd42 to 8439351 Compare April 9, 2022 07:17
@eugenejahn
Copy link
Contributor Author

Got it! Pushed!

anrusina
anrusina approved these changes Apr 9, 2022
View reviewed changes
Copy link
Contributor

@anrusina anrusina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, Thank you! 🚀

@anrusina anrusina merged commit 55c63d2 into flyteorg:master Apr 9, 2022
@welcome
Copy link

welcome bot commented Apr 9, 2022

Congrats on merging your first pull request! 🎉

flyte-bot added a commit that referenced this pull request Apr 9, 2022
@flyte-bot
chore(release): Release 0.50.3 [skip ci]
5f61ea5 
## [0.50.3](http://github.com/lyft/flyteconsole/compare/v0.50.2...v0.50.3) (2022-04-09)

### Bug Fixes

* fixed the css to avoid overflow and add the duration back to the table ([#368](http://github.com/lyft/flyteconsole/issues/368)) ([55c63d2](http://github.com/lyft/flyteconsole/commit/55c63d2145b9faafade9132aec6db06cd632eb95))
* return back static assets folder ([#366](http://github.com/lyft/flyteconsole/issues/366)) ([067e61d](http://github.com/lyft/flyteconsole/commit/067e61d83c7b6e50378c13fb0616abf4614f1348))
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.50.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anrusina anrusina anrusina approved these changes

@ursucarina ursucarina Awaiting requested review from ursucarina ursucarina was automatically assigned from flyteorg/fe-engineers

@jsonporter jsonporter Awaiting requested review from jsonporter jsonporter was automatically assigned from flyteorg/fe-engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Confirmation Buttons Overflow on Execution Table
3 participants
@eugenejahn @flyte-bot @anrusina