Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Confirmation Buttons Overflow on Execution Table #368

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ export const WorkflowExecutionRow: React.FC<WorkflowExecutionRowProps> = ({
onCancel: () => setShowConfirmation(false),
onConfirmClick: onArchiveConfirmClick,
});
const columnsWithApproval = [...columns.slice(0, -2), confirmation];
// To hide the onHover action buttons,
// we take off the last column which is onHover actions buttons
const columnsWithApproval = [...columns.slice(0, -1), confirmation];

// we show error info only on active items
const { abortMetadata, error } = execution.closure;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ export const useStyles = makeStyles((theme: Theme) => ({
},
confirmationButton: {
borderRadius: 0,
minWidth: '100px',
// make the button responsive, so the button won't overflow
width: '50%',
minHeight: '53px',
// cancel margins that are coming from table row style
marginTop: theme.spacing(-1),
Expand Down