-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow to archive workflow from flyteconsole #361
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 66.01% 66.43% +0.42%
==========================================
Files 402 405 +3
Lines 8965 9045 +80
Branches 1580 1594 +14
==========================================
+ Hits 5918 6009 +91
+ Misses 3047 3036 -11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job overall, left few comments mainly about styling
src/components/Workflow/__stories__/SearchableWorkflowNameList.stories.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
854e3ed
to
2c90136
Compare
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly lgtm, need some updates in description and button clarifications.
src/components/Workflow/filters/useWorkflowShowArchivedState.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Great Job
🚀 🥳
Congrats on merging your first pull request! 🎉 |
# [0.51.0](http://github.com/lyft/flyteconsole/compare/v0.50.4...v0.51.0) (2022-04-12) ### Bug Fixes * add more descriptive errors on task/workflow run failure ([#370](http://github.com/lyft/flyteconsole/issues/370)) ([4e501fa](http://github.com/lyft/flyteconsole/commit/4e501faae1fd46faba268d2803c7c5452fcc3c60)) ### Features * Allow to archive workflow from flyteconsole ([#361](http://github.com/lyft/flyteconsole/issues/361)) ([1ed28c4](http://github.com/lyft/flyteconsole/commit/1ed28c4d566def6f286e164744c8da7e68f8d898))
🎉 This PR is included in version 0.51.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Signed-off-by: Carina Ursu carina@union.ai
New feature: Archive/Unarchive workflows
Archive Button: https://share.getcloudapp.com/d5u9nvpy
Archive Actions: https://share.getcloudapp.com/p9u6Q7r2
TL;DR
Allows to filter workflows by archive state in the console, and for individual workflows to be archived/unarchived
Type
Are all requirements met?
Complete description
Added WorkflowExecutionState enum and calls to NamedEntityUpdate
Added notistack to support error and success notifications
Ensured that items could be archived and unarchived from "workflow"
Updates storybook to observe all recent changes
Added "localization" string support
Tracking Issue
adds feature for https://github.com/flyteorg/flyteconsole/issues/320