feat: Allow to archive workflow from flyteconsole #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ursucarina
requested review from
anrusina,
olga-union,
a team and
jsonporter
and removed request for
a team
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 66.01% 66.43% +0.42%
==========================================
Files 402 405 +3
Lines 8965 9045 +80
Branches 1580 1594 +14
==========================================
+ Hits 5918 6009 +91
+ Misses 3047 3036 -11
Continue to review full report at Codecov.
|
anrusina
reviewed
Apr 8, 2022
src/components/Workflow/__stories__/SearchableWorkflowNameList.stories.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
ursucarina
force-pushed
the
carina/wfarchive
branch
from
854e3ed
to
2c90136
Compare
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
ursucarina
changed the title
olga-union
reviewed
Apr 11, 2022
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
olga-union
reviewed
Apr 11, 2022
Signed-off-by: Carina Ursu <[email protected]>
anrusina
reviewed
Apr 11, 2022
src/components/Workflow/filters/useWorkflowShowArchivedState.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
|
Congrats on merging your first pull request! 🎉 |
flyte-bot
added a commit
that referenced
this pull request
Apr 12, 2022
# [0.51.0](http://github.com/lyft/flyteconsole/compare/v0.50.4...v0.51.0) (2022-04-12) ### Bug Fixes * add more descriptive errors on task/workflow run failure ([#370](http://github.com/lyft/flyteconsole/issues/370)) ([4e501fa](http://github.com/lyft/flyteconsole/commit/4e501faae1fd46faba268d2803c7c5452fcc3c60)) ### Features * Allow to archive workflow from flyteconsole ([#361](http://github.com/lyft/flyteconsole/issues/361)) ([1ed28c4](http://github.com/lyft/flyteconsole/commit/1ed28c4d566def6f286e164744c8da7e68f8d898))
|
🎉 This PR is included in version 0.51.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carina Ursu [email protected]
New feature: Archive/Unarchive workflows
Archive Button: https://share.getcloudapp.com/d5u9nvpy
Archive Actions: https://share.getcloudapp.com/p9u6Q7r2
TL;DR
Allows to filter workflows by archive state in the console, and for individual workflows to be archived/unarchived
Type
Are all requirements met?
Complete description
Added WorkflowExecutionState enum and calls to NamedEntityUpdate
Added notistack to support error and success notifications
Ensured that items could be archived and unarchived from "workflow"
Updates storybook to observe all recent changes
Added "localization" string support
Tracking Issue
adds feature for https://github.com/flyteorg/flyteconsole/issues/320