fix: add more descriptive errors on task/workflow run failure #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eugenejahn <[email protected]>
anrusina
requested review from
a team,
ursucarina,
anrusina and
jsonporter
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
==========================================
- Coverage 66.01% 66.00% -0.01%
==========================================
Files 402 402
Lines 8965 8976 +11
Branches 1580 1583 +3
==========================================
+ Hits 5918 5925 +7
- Misses 3047 3051 +4
Continue to review full report at Codecov.
|
anrusina
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
It looks great! 🚀
Currently we do not have a decode type for such errors, so what you did is probably the best that can be achieved.
I fully agree with you that it is a best place to put it in, as it planned to be used with transformRequestError only at this point.
flyte-bot
added a commit
that referenced
this pull request
Apr 12, 2022
# [0.51.0](http://github.com/lyft/flyteconsole/compare/v0.50.4...v0.51.0) (2022-04-12) ### Bug Fixes * add more descriptive errors on task/workflow run failure ([#370](http://github.com/lyft/flyteconsole/issues/370)) ([4e501fa](http://github.com/lyft/flyteconsole/commit/4e501faae1fd46faba268d2803c7c5452fcc3c60)) ### Features * Allow to archive workflow from flyteconsole ([#361](http://github.com/lyft/flyteconsole/issues/361)) ([1ed28c4](http://github.com/lyft/flyteconsole/commit/1ed28c4d566def6f286e164744c8da7e68f8d898))
|
🎉 This PR is included in version 0.51.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: eugenejahn [email protected]
Not sure should I suppose to fix this... I was trying to fix https://github.com/flyteorg/flyteconsole/issues/336, but kind of annoyed by not seeing the error message, so I just fix it. (may not be 100% complete)
Enrich the error message. In launch form, users should see a complete error message from the API response
After fixed:
Type
Are all requirements met?
Complete description
I decoded the response from the api and return it as new error. However, one thing I am not quite sure is do we have a decode type for the error message? now, I am just using RawOutputDataConfig type to decode...
also since I don't think we will use decodeErrorResponseMessage in other place, I didn't put in ./utils. Let me know if you want me to put into utils.
Tracking Issue
fixes https://github.com/flyteorg/flyteconsole/issues/337