Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 'Only Mine' toggle for execution tasks list #343

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

olga-union
Copy link
Contributor

Signed-off-by: Olga Nad [email protected]

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Description

This is a copy of #335 with commit sign-offs fixed!

Added Only my executions filter, removed old filter, removed unused fields on the FilterState, updated UserProfile type field to match API data object. Added tests, updated storybook.

Demos

https://user-images.githubusercontent.com/101579322/159072610-f54bc16d-688b-4a64-bc04-5dd3339ca4fd.mov
https://user-images.githubusercontent.com/101579322/159072616-156479d1-99d8-4e73-8df5-ff5e083531c4.mov
https://user-images.githubusercontent.com/101579322/159072621-d2a056ba-891d-4c0d-b527-fd74339ed35f.mov

Copy link
Contributor

@jsonporter jsonporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@jsonporter jsonporter merged commit 3b62b27 into master Mar 23, 2022
@jsonporter jsonporter deleted the olga-union/v2-add-only-my-executions-filter branch March 23, 2022 16:54
@welcome
Copy link

welcome bot commented Mar 23, 2022

Congrats on merging your first pull request! 🎉

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.47.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants