feat: 'Only Mine' toggle for execution tasks list #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
anrusina
reviewed
Mar 19, 2022
Comment on lines
60
to
64
| onlyMyExecutionsFilterState?: { | ||
| onlyMyExecutionsValue: boolean; | ||
| isFilterDisabled: boolean; | ||
| onOnlyMyExecutionsFilterChange: (filterOnlyMyExecutions: boolean) => void; | ||
| }; |
There was a problem hiding this comment.
nit: create a separate type/interface for onlyMyState, to use here as:
onlyMyExecutionsFilterState?: OnlyMyState; for better readability
Signed-off-by: olga-union <[email protected]>
Signed-off-by: olga-union <[email protected]>
olga-union
force-pushed
the
olga-union/add-only-my-executions-filter
branch
from
3cf1f96 to
816f1ec
Compare
olga-union
changed the title
olga-union
commented
Mar 21, 2022
Comment on lines
+14
to
+25
| describe.each` | ||
| isFilterDisabled | initialValue | expected | ||
| ${undefined} | ${undefined} | ${{ isFilterDisabled: false, onlyMyExecutionsValue: false }} | ||
| ${false} | ${undefined} | ${{ isFilterDisabled: false, onlyMyExecutionsValue: false }} | ||
| ${true} | ${undefined} | ${{ isFilterDisabled: true, onlyMyExecutionsValue: false }} | ||
| ${undefined} | ${false} | ${{ isFilterDisabled: false, onlyMyExecutionsValue: false }} | ||
| ${undefined} | ${true} | ${{ isFilterDisabled: false, onlyMyExecutionsValue: true }} | ||
| ${false} | ${false} | ${{ isFilterDisabled: false, onlyMyExecutionsValue: false }} | ||
| ${false} | ${true} | ${{ isFilterDisabled: false, onlyMyExecutionsValue: true }} | ||
| ${true} | ${false} | ${{ isFilterDisabled: true, onlyMyExecutionsValue: false }} | ||
| ${true} | ${true} | ${{ isFilterDisabled: true, onlyMyExecutionsValue: true }} | ||
| `('for each case', ({ isFilterDisabled, initialValue, expected }) => { |
There was a problem hiding this comment.
Initially wrote this up as individual tests, but thought this may be a good use case to digest them as a table. I have the original code handy, so wouldn't be a problem to revert, if it's just my taste :)
There was a problem hiding this comment.
I don't have any particular taste, but curious how it will look like if one of them fails?
There was a problem hiding this comment.
@anrusina only failed cases will show up, like in this screenshot, test case title is customized on line 26, and I just stringified expected to show value instead of [Object Object]
Signed-off-by: Olga Nad <[email protected]>
…o olga-union/add-only-my-executions-filter
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 65.14% 65.16% +0.02%
==========================================
Files 390 390
Lines 8707 8699 -8
Branches 1506 1504 -2
==========================================
- Hits 5672 5669 -3
+ Misses 3035 3030 -5
Continue to review full report at Codecov.
|
Signed-off-by: Olga Nad <[email protected]>
Signed-off-by: olga-union <[email protected]> Signed-off-by: Olga Nad <[email protected]>
Signed-off-by: olga-union <[email protected]> Signed-off-by: Olga Nad <[email protected]>
Signed-off-by: Olga Nad <[email protected]>
Signed-off-by: Olga Nad <[email protected]>
* feat: added RawOutputDataConfig in ExecutionSpec Signed-off-by: Kevin Su [email protected] Signed-off-by: Olga Nad <[email protected]>
# [0.46.0](http://github.com/lyft/flyteconsole/compare/v0.45.0...v0.46.0) (2022-03-18) ### Features * added RawOutputDataConfig in ExecutionSpec #patch ([#329](http://github.com/lyft/flyteconsole/issues/329)) ([24bdaee](http://github.com/lyft/flyteconsole/commit/24bdaeefcf32c079d1aaeb54b28cc6bf7395b42f)) Signed-off-by: Olga Nad <[email protected]>
Signed-off-by: Olga Nad <[email protected]>
Signed-off-by: Olga Nad <[email protected]>
Signed-off-by: Olga Nad <[email protected]>
…thub.com/flyteorg/flyteconsole into add-only-my-executions-filter
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Are all requirements met?
Description
Closed in favor of #343
Added
Only my executionsfilter, removed old filter, removed unused fields on theFilterState, updatedUserProfiletype field to match API data object. Added tests, updated storybook.Demos
https://user-images.githubusercontent.com/101579322/159072610-f54bc16d-688b-4a64-bc04-5dd3339ca4fd.mov
https://user-images.githubusercontent.com/101579322/159072616-156479d1-99d8-4e73-8df5-ff5e083531c4.mov
https://user-images.githubusercontent.com/101579322/159072621-d2a056ba-891d-4c0d-b527-fd74339ed35f.mov