fix: perform login redirect automatically #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 74.43% 74.30% -0.14%
==========================================
Files 415 414 -1
Lines 7310 7304 -6
Branches 1154 1155 +1
==========================================
- Hits 5441 5427 -14
- Misses 1869 1877 +8
Continue to review full report at Codecov.
|
BobNisco
approved these changes
Jan 12, 2021
Closed
13 tasks
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Jan 12, 2021
## [0.19.1](http://github.com/lyft/flyteconsole/compare/v0.19.0...v0.19.1) (2021-01-12) ### Bug Fixes * perform login redirect automatically ([#137](http://github.com/lyft/flyteconsole/issues/137)) ([9f09aa2](http://github.com/lyft/flyteconsole/commit/9f09aa2bdeb0929f18b0b5d853fddaae4bc808d3))
|
🎉 This PR is included in version 0.19.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#525
This is a small update to remove the dialog we show when we detect that the session has expired and just perform the redirect automatically.
Has been tested on latest Chrome, Firefox, and Safari.
LoginExpiredHandlerapiContextto detect when expiration state changes and redirect to the login url