Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console should automatically perform login redirect for unauthenticated users #525

Closed
1 of 13 tasks
schottra opened this issue Sep 25, 2020 · 1 comment
Closed
1 of 13 tasks
Assignees
Labels
enhancement New feature or request ui Admin console user interface

Comments

@schottra
Copy link
Contributor

Motivation: Why do you think this is important?
When hitting FlyteConsole for the first time, users are often immediately presented with a dialog letting them know they need to log in. The original purpose of this dialog was to support an edge case of being able to refresh credentials for a user without having to leave an already rendered view. But the current implementation is just a placeholder for being able to do the login flow in a separate tab. The more common case is that users are forced to do an additional click when they are loading the app for the first time after credentials expire. This is unnecessary and a little obnoxious.
For now, we should remove the intermediate dialog and just do the authentication redirect immediately.

We can add a separate issue to support redirect-less credential refreshes later on.

Goal: What should the final outcome look like, ideally?
User does not need an additional click to perform the login flow when loading Flyte Console.

Describe alternatives you've considered
N/A

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other
@schottra schottra added enhancement New feature or request ui Admin console user interface efficiency labels Sep 25, 2020
@schottra schottra self-assigned this Jan 11, 2021
@schottra
Copy link
Contributor Author

fixed by flyteorg/flyteconsole#137
available in flyteconsole v0.19.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Admin console user interface
Projects
None yet
Development

No branches or pull requests

1 participant