feat: adds project-level executions view #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 73.35% 74.43% +1.07%
==========================================
Files 411 415 +4
Lines 7222 7310 +88
Branches 1129 1154 +25
==========================================
+ Hits 5298 5441 +143
+ Misses 1924 1869 -55
Continue to review full report at Codecov.
|
BobNisco
previously approved these changes
Jan 9, 2021
BobNisco
approved these changes
Jan 9, 2021
13 tasks
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Jan 9, 2021
# [0.19.0](http://github.com/lyft/flyteconsole/compare/v0.18.0...v0.19.0) (2021-01-09) ### Features * adds project-level executions view ([#135](http://github.com/lyft/flyteconsole/issues/135)) ([d8daf6c](http://github.com/lyft/flyteconsole/commit/d8daf6c503810ffc06976c399ddf35e982c0f2e9))
|
🎉 This PR is included in version 0.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#581
This adds a new tab/view to the ProjectDetails page which will show executions for a given project/domain combo. It uses the existing infrastructure for rendering a scoped project-level view and uses the recent react-query patterns and
useInfiniteQueryto power the list (instead of the legacyuseWorkflowExecutionshook).Stateobject just to determine if a fetch is in progress. They now accept a simple boolean which can be derived from aStateusingisLoadingStateor from aQueryObserverusingquery.isFetching.tokenthat is compatible withuseInfiniteQueryworkflowExecutionQueriesmodule with a query generator for a list of Workflow Executions based on the new query wrapper.WorkflowExecutionsTablebased on the results of our new executions query.WorkflowExecutionsTablethat controls showing the workflow name of an execution in place of theLast run...string. This is useful in the generic case where the table is showing a mixture of executions from different workflows and the execution name/link isn't enough information to distinguish between them.WorkflowExecutionsTableand added a simplified mock version which does not usereact-virtualizedto make it possible to test views which use the table (Autosizer and CellMeasurer do not work in jsdom).listWorkflowExecutionsresponse, which is used in the tests forProjectExecutions