fix: convert empty array literals to empty collection literals #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wild-endeavor
approved these changes
Nov 16, 2020
20 tasks
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Nov 16, 2020
## [0.17.7](http://github.com/lyft/flyteconsole/compare/v0.17.6...v0.17.7) (2020-11-16) ### Bug Fixes * convert empty array literals to empty collection literals ([#121](http://github.com/lyft/flyteconsole/issues/121)) ([7f42a11](http://github.com/lyft/flyteconsole/commit/7f42a114980f9c0f38786fbc30ee8131e6bb4814))
|
🎉 This PR is included in version 0.17.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This change ensures that the empty array literal string (
"[]") is correctly converted to aCore.ILiteralcollection with an emptyliteralsproperty.Type
Are all requirements met?
Complete description
The original implementation incorrectly determined that an empty array literal string should be converted to a
NonetypeLiteral. This is equivalent to passingvoid/nullfor the value, which is not correct. I updated the code to continue trying to parse the inner value (which will be an empty JS array), resulting in the properLiteralvalue being returned.Tracking Issue
flyteorg/flyte#533
Follow-up issue
NA