fix: convert empty array literals to empty collection literals (#121)

flyteorg · Nov 16, 2020 · 7f42a11 · 7f42a11
1 parent 8c84d02
commit 7f42a11
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 4 deletions.
diff --git a/src/components/Launch/LaunchForm/inputHelpers/collection.ts b/src/components/Launch/LaunchForm/inputHelpers/collection.ts
@@ -64,9 +64,6 @@ function toLiteral({
             return literalNone();
         }
         parsed = parseCollection(stringValue);
-        if (!parsed.length) {
-            return literalNone();
-        }
     }
 
     const helper = getHelperForInput(subtype.type);

diff --git a/src/components/Launch/LaunchForm/inputHelpers/test/inputHelpers.test.ts b/src/components/Launch/LaunchForm/inputHelpers/test/inputHelpers.test.ts
@@ -1,7 +1,7 @@
 import { stringifyValue } from 'common/utils';
 import { Core } from 'flyteidl';
 import * as Long from 'long';
-import { BlobDimensionality } from 'models';
+import { BlobDimensionality, SimpleType } from 'models';
 import {
     collectionInputTypeDefinition,
     nestedCollectionInputTypeDefinition,
@@ -207,6 +207,34 @@ describe('inputToLiteral', () => {
                 ).toEqual(output);
             });
         });
+
+        it('should convert empty array string literal to empty collection', () => {
+            const input = makeCollectionInput(
+                {
+                    type: InputType.String,
+                    literalType: { simple: SimpleType.STRING }
+                },
+                '[]'
+            );
+            const expected: Core.ILiteral = {
+                collection: { literals: [] }
+            };
+            expect(inputToLiteral(input)).toEqual(expected);
+        });
+
+        it('should convert nested empty array string literal to nested empty collection', () => {
+            const input = makeNestedCollectionInput(
+                {
+                    type: InputType.String,
+                    literalType: { simple: SimpleType.STRING }
+                },
+                '[[]]'
+            );
+            const expected: Core.ILiteral = {
+                collection: { literals: [{ collection: { literals: [] } }] }
+            };
+            expect(inputToLiteral(input)).toEqual(expected);
+        });
     });
 
     describe('Unsupported Types', () => {