Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve UX for Single Task Executions #103

Merged
merged 6 commits into from
Oct 8, 2020
Merged

Conversation

schottra
Copy link
Contributor

@schottra schottra commented Oct 8, 2020

This branch enhances support for Single Task Executions in Flyte Console. See flyteorg/flyte#459.

  • The Task list now renders clickable entries which will navigate to the Task Details page for the given Task
  • Added a Task Details view, which is very similar to the Workflow Details view, but focused on a Task. This view shows the description, execution history (currently broken by [BUG] List single task executions for a task doesn't work flyte#542), and a Launch button for the Task.
  • Refactored the Launch form to allow for Task as a source. When using a Task source, only the version needs to be selected. Tasks do not have Launch Plans, so all inputs are required in order to submit.
  • Refactored the Relaunch/Clone form to correctly handle executions which were created with a Task as the source.
  • Relaunch flow now correctly sets the referenceExecution field, and the ExecutionDetails view will render a "related to" item for the referenceExecution if it is present.

The following PRs are included here and have been separately reviewed:
#96
#97
#99
#100
#101
#102

)

* refactor: make workflow details generic so it can be used for tasks

* chore: cleanup and moving tests over
* refactor: filling out details of the state machine for launch

* refactor: checkpoint

* refactor: mostly finished wiring of machine to component state

* refactor: more work to get form component migrated to using machine

* refactor: cleaning up state for selectors

* fix: type error due to patch version upgrade

* refactor: trying a flat state structure

* fix: getting all tests passing again

* chore: cleanup and docs

* chore: pull request feedback
* refactor: splitting launch machine into two separate types

* refactor: move shared state out to component

* refactor: use composition to create workflow form

* refactor: update usage of LaunchWorkflowForm -> LaunchForm

* chore: cleanup and fix tests
* feat: add task support in launch components

* test: updating launch form tests to handle task cases

* fix: remaining broken tests
* feat: add support for launch tasks in entity details view

* fix: correctly map initial parameters when relaunching

* fix: correct parent name and back link in execution details page

* fix: pass through referenceExecution when relaunching

* test: check rendering of referenceExecution

* test: adding tests for relaunch flow
@service-github-lyft-semantic-release
Copy link
Contributor

🎉 This PR is included in version 0.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants