-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make workflow details generic so it can be used for tasks #96
Conversation
Codecov Report
@@ Coverage Diff @@
## single-task-execution #96 +/- ##
=========================================================
+ Coverage 67.50% 67.54% +0.04%
=========================================================
Files 371 372 +1
Lines 5992 6021 +29
Branches 932 945 +13
=========================================================
+ Hits 4045 4067 +22
- Misses 1947 1954 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* refactor: make workflow details generic so it can be used for tasks (#96) * refactor: make workflow details generic so it can be used for tasks * chore: cleanup and moving tests over * feat: adding route and navigation to the task details page (#97) * Refactor Launch form to use a state machine (#99) * refactor: filling out details of the state machine for launch * refactor: checkpoint * refactor: mostly finished wiring of machine to component state * refactor: more work to get form component migrated to using machine * refactor: cleaning up state for selectors * fix: type error due to patch version upgrade * refactor: trying a flat state structure * fix: getting all tests passing again * chore: cleanup and docs * chore: pull request feedback * refactor: Make launch state and components generic (#100) * refactor: splitting launch machine into two separate types * refactor: move shared state out to component * refactor: use composition to create workflow form * refactor: update usage of LaunchWorkflowForm -> LaunchForm * chore: cleanup and fix tests * feat: Add Task support to Launch form (#101) * feat: add task support in launch components * test: updating launch form tests to handle task cases * fix: remaining broken tests * Cleanup work for launching single task executions. (#102) * feat: add support for launch tasks in entity details view * fix: correctly map initial parameters when relaunching * fix: correct parent name and back link in execution details page * fix: pass through referenceExecution when relaunching * test: check rendering of referenceExecution * test: adding tests for relaunch flow
# [0.13.0](http://github.com/lyft/flyteconsole/compare/v0.12.1...v0.13.0) (2020-10-08) ### Features * Improve UX for Single Task Executions ([#103](http://github.com/lyft/flyteconsole/issues/103)) ([d0335dc](http://github.com/lyft/flyteconsole/commit/d0335dc1f86b98b30011e63d686b8168262d3bbd)), closes [#96](http://github.com/lyft/flyteconsole/issues/96) [#97](http://github.com/lyft/flyteconsole/issues/97) [#99](http://github.com/lyft/flyteconsole/issues/99) [#100](http://github.com/lyft/flyteconsole/issues/100) [#101](http://github.com/lyft/flyteconsole/issues/101) [#102](http://github.com/lyft/flyteconsole/issues/102)
flyteorg/flyte#459
Tasks/Workflows have a lot of similar information. The details view only really differs in whether or not we want to show schedules and what filter we need to use to fetch the executions.
So as a preparatory step for showing task details, this change moves all of the WorkflowDetails logic into a shared set of
Entity
components. Rendering the details for an entity only requires passing aResourceIdentifier
. The individual view components will be responsible for pulling the correct values from the route and rendering aEntityDetails
component using the rightresourceType
value.Note While the work has been done to enable showing Task details, it isn't hooked up yet. That will be in a follow-up PR.
components/Entities
folder to hold components which are common across entity types (workflow, launch plan, task, etc..)WorkflowDetails
into the new components folderEntityDetails
components generic based on a passedResourceIdentifier