added pt translations #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadar
suggested changes
Oct 12, 2022
src/messages/pt/forms.php
Outdated
| 'form_model_email_intro_hint' => 'O texto deste campo será usado como texto de introdução para o e-mail. Todas as variáveis especificadas podem ser inseridas com {{attribute}}.', | ||
| 'form_model_email_recipients_hint' => 'Se nenhum destinatário for fornecido, o envio do formulário não acionará um e-mail.', | ||
| 'form_model_subject_hint' => 'Assunto do e-mail. Se não for especificado, o título do formulário será usado.', | ||
| 'As Hidden Input Value' => '', |
There was a problem hiding this comment.
There are many missing translations. Maybe you where taking a look at the en file, but as those strings are english, they don't need translation. Here in the german file you can see they are all translated.
https://github.com/luyadev/luya-module-forms/blob/master/src/messages/de/forms.php
|
Thanks for taking time, some missing translations, afterwards LGTM 👍 |
nadar
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing/introducing
Added pt translations (added pt folder)
What is the reason for changing/introducing
Added pt translations for portuguese users
QA