Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent namespace for XML mapping #150

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

suleman-uzair
Copy link

@Novtopro @ronaldtse I faced a similar issue as mentioned here => lutaml/oasis-etm#1 (comment), while integrating lutaml/lutaml-model in plurimath/mml#2.

Opened this PR after discussing with @HassanAkbar.

@Novtopro let me know if this helps in your case.


xml do
root "Parent"
namespace "https://abc.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the test we should test additional nesting levels and when the namespaces change in between. If the parent and child both have the same namespace, what happens? Need to update documentation. Going to approve and merge this first.


xml do
root "Parent"
namespace "https://abc.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the test we should test additional nesting levels and when the namespaces change in between. If the parent and child both have the same namespace, what happens? Need to update documentation. Going to approve and merge this first.

@ronaldtse ronaldtse merged commit 6c4d5b6 into main Nov 5, 2024
13 of 14 checks passed
@ronaldtse ronaldtse deleted the default-namespace-for-xml-mapping branch November 5, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants