Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/set version for sentry #3449

Merged
merged 3 commits into from
Jan 21, 2020
Merged

Fabo/set version for sentry #3449

merged 3 commits into from
Jan 21, 2020

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Jan 20, 2020

Sets the version to be displayed in Sentry along the error. So we see which version the user is executing.

@faboweb faboweb requested a review from jbibla as a code owner January 20, 2020 21:42
@Bitcoinera
Copy link
Contributor

Bitcoinera commented Jan 21, 2020

Brilliant! But why did the netlify deployment failed?

@jbibla jbibla merged commit 455ec95 into develop Jan 21, 2020
@jbibla jbibla deleted the fabo/set-version-for-sentry branch January 21, 2020 18:03
@Bitcoinera
Copy link
Contributor

Cool. Good catch @jbibla

faboweb referenced this pull request Jan 28, 2020
* added script to add version file on build

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants