Fabo/set version for sentry (#3449)

* set sentry version * changelog * lack of stringification was breaking builds Co-authored-by: Jordan Bibla <[email protected]>
luniehq · Jan 21, 2020 · 455ec95 · 455ec95
1 parent c09208d
commit 455ec95
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/changes/fabo_set-version-for-sentry b/changes/fabo_set-version-for-sentry
@@ -0,0 +1 @@
+[Repository] Set Lunie version for Sentry @faboweb
diff --git a/src/main.js b/src/main.js
@@ -20,7 +20,8 @@ import "material-design-icons-iconfont/dist/material-design-icons.css"
 if (config.sentryDSN) {
   Sentry.init({
     dsn: config.sentryDSN,
-    integrations: [new Integrations.Vue({ Vue, attachProps: true })]
+    integrations: [new Integrations.Vue({ Vue, attachProps: true })],
+    release: process.env.LUNIE_VERSION
   })
 }
 

diff --git a/vue.config.js b/vue.config.js
@@ -1,16 +1,12 @@
 const path = require(`path`)
 const webpack = require(`webpack`)
 const CSPWebpackPlugin = require(`csp-webpack-plugin`)
+const { version } = require("./package.json")
 
 function resolve(dir) {
   return path.join(__dirname, dir)
 }
 
-const commitHash = require(`child_process`)
-  .execSync(`git rev-parse HEAD`)
-  .toString()
-  .trim()
-
 module.exports = {
   publicPath: `/`,
   chainWebpack: config => {
@@ -41,7 +37,7 @@ module.exports = {
             NODE_ENV: JSON.stringify(process.env.NODE_ENV),
             NETWORK: JSON.stringify(process.env.NETWORK),
             SENTRY_DSN: JSON.stringify(process.env.SENTRY_DSN),
-            RELEASE: JSON.stringify(commitHash),
+            LUNIE_VERSION: JSON.stringify(version),
             GOOGLE_ANALYTICS_UID: JSON.stringify(
               process.env.GOOGLE_ANALYTICS_UID
             ),
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		[Repository] Set Lunie version for Sentry @faboweb