Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webpack environment variables #2120

Merged
merged 4 commits into from
Feb 28, 2019
Merged

Fix webpack environment variables #2120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d17042
fix webpack environment variables
sabau Feb 27, 2019
eaff574
faucet deserve his places in the olympus of the env variables
sabau Feb 28, 2019
0dda8c5
revert to DefinePlugin, we have more control
sabau Feb 28, 2019
fe54055
Update webpack.renderer.config.js
sabau Feb 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- [\#2015](https://github.com/cosmos/voyager/issues/2015) fixed error that showed wrong message when Ledger's screensaver mode was on @fedekunze
- Reconnected event was not triggered after reconnection @faboweb
- [\#2094](https://github.com/cosmos/voyager/pull/2094) fix Toolbar @faboweb
- Fix Webpack Env variables @sabau

### Changed

Expand Down
11 changes: 6 additions & 5 deletions webpack.renderer.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,13 @@ const rendererConfig = {
new webpack.DefinePlugin({
"global.GENTLY": false
}),
new webpack.DefinePlugin({
"process.env.RELEASE": `"${commitHash}"`
}),
new webpack.DefinePlugin({
"process.env": {
NODE_ENV: JSON.stringify(process.env.NODE_ENV)
NODE_ENV: JSON.stringify(process.env.NODE_ENV),
FAUCET: JSON.stringify(process.env.FAUCET),
RPC: JSON.stringify(process.env.RPC),
STARGATE: JSON.stringify(process.env.STARGATE),
RELEASE: JSON.stringify(commitHash)
}
}),
new HtmlWebpackPlugin({
Expand Down Expand Up @@ -210,4 +211,4 @@ if (process.env.RELEASE) {
)
}

module.exports = rendererConfig
module.exports = rendererConfig