Fix webpack environment variables #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karoly Albert Szabo <[email protected]>
Signed-off-by: Karoly Albert Szabo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #2120 +/- ##
========================================
Coverage 95.31% 95.31%
========================================
Files 110 110
Lines 2581 2581
Branches 104 104
========================================
Hits 2460 2460
Misses 112 112
Partials 9 9 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #2120 +/- ##
========================================
Coverage 95.31% 95.31%
========================================
Files 110 110
Lines 2581 2581
Branches 104 104
========================================
Hits 2460 2460
Misses 112 112
Partials 9 9 |
faboweb
reviewed
Feb 28, 2019
webpack.renderer.config.js
Outdated
| NODE_ENV: JSON.stringify(process.env.NODE_ENV) | ||
| } | ||
| }), | ||
| new webpack.EnvironmentPlugin([`NODE_ENV`, `RELEASE`, `STARGATE`, `RPC`, `RELEASE`, `FAUCET`]), |
There was a problem hiding this comment.
Suggested change
| new webpack.EnvironmentPlugin([`NODE_ENV`, `RELEASE`, `STARGATE`, `RPC`, `RELEASE`, `FAUCET`]), | |
| new webpack.EnvironmentPlugin([`NODE_ENV`, `STARGATE`, `RPC`, `RELEASE`, `FAUCET`]), |
There was a problem hiding this comment.
Thanks! I think I will fall back on the dear old DefinePlugin, MacOS and linux behave slightly differently (or can be just different types of shells) with this one, it seems to just forward
- Different behaviour for falsey values like empty strings on different OS
faboweb
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Thank you! 🚀
For contributor:
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: