Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back-button behaviour #70

Closed
faboweb opened this issue Nov 21, 2017 · 6 comments
Closed

Back-button behaviour #70

faboweb opened this issue Nov 21, 2017 · 6 comments
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@faboweb
Copy link
Collaborator

faboweb commented Nov 21, 2017

The back button behavior is not consistent in the application. Sometimes it is there, sometimes it isn't. It also does not work like expected (going back to the last view) in some cases.
@faboweb faboweb added bug 🐛 issues related to unhandled errors in the code that need to be fixed enhancement labels Nov 21, 2017
@faboweb
Copy link
Collaborator Author

faboweb commented Nov 21, 2017

Decided on go back in page history.

@jbibla jbibla added the design-work-needed 🎨 issues that require design work before development label Nov 21, 2017
@faboweb faboweb added question and removed design-work-needed 🎨 issues that require design work before development labels Nov 21, 2017
@jbibla
Copy link
Collaborator

jbibla commented Nov 21, 2017

requires further thought / discussion @nylira

@nylira
Copy link
Contributor

nylira commented Nov 21, 2017

Go back in page history works for me. The sidebar lets you go anywhere else the user may want to. @jolesbi?

@nylira
Copy link
Contributor

nylira commented Nov 23, 2017

I've been thinking about this and I think it's best to just remove the back button. This app is not a web browser, and shouldn't have the concept of going back a page. Having no back button will also force us to evaluate the rest of the app navigation to make sure it functions well with hierarchical navigation.

@faboweb
Copy link
Collaborator Author

faboweb commented Nov 24, 2017 •
edited
Loading

Counter proposal (leave as is :)):
Right now we have a back-button on level 2 hierarchy views i.e. Candidates / Candidate.
Use-case where this is necessary: Mobile-view (where there is no side menu) -> Switching between candidates / transactions
We could try to limit ourselves to those 2 levels of hierarchy (as is right now I believe).

But it's not that important to me and I trust our designers. In the end we will have to adjust to user feedback anyway.

@nylira
Copy link
Contributor

nylira commented Nov 25, 2017

Thumbs up for leave as-is. It's making more sense with the desktop header navigation.

@nylira nylira closed this as completed Dec 5, 2017
faboweb added a commit that referenced this issue Jun 2, 2020
@faboweb
Merge pull request #70 from luniehq/Benji/30-API-Moniker-Query
ee8b5b9 
Benji/30 api moniker query
faboweb pushed a commit that referenced this issue Jun 2, 2020
@colw @faboweb
Return delegations and rewards from store (#70)
f19c590 
* Return delegations and rewards from store

* overview values

* Remove unnecessary Promise.all
faboweb added a commit that referenced this issue Jun 2, 2020
@faboweb
Update production (#75)
5a468dc 
* added node install to docker

* run npm install correct

* don't copy modules

* use env variables for testnet

* Update pr.yml

* github workflows changes

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Make search case-insensitive (#36)

Modify variable names for clarity.

* Query balance by denomination (#48)

* colw/subscription-fix (#47)

* Fix transaction destructure

* Lint

* Rename for consistency

* Override method for V2

* Colw/fix denom and votes (#49)

* Use larger denom for governance parameters

* Lint

* Fix: Leave in big number format for line #86

* Fabo/minor fixes (#51)

* gracefully handle no rewards

* always return balance

* prevent error when no rewards

* fix wrong delegation amount showing

* log transaction if tag is empty (#58)

* fix tally for running proposals (#54)

* Fabo/move testnet definition into network configs file (#56)

* move testnet definition into network configs file

* use configs for endpoints

* update cache key per block (#57)

* colw/minor-fixes (#59)

* Export testnet data for use in LunieDB Source

* Fix get query

* Mario/32 add proposal proposer (#52)

* Add proposal proposer

* Add proposer to proposals page

* Revert package.js mod, use Promise.all

* Call all queries at same time in getProposalById

* Api error 500 fix

* Fabo suggestions

* Add cross-env

* Resolve merge conflict

* Fix merge error

* deliver correct testnet url (#60)

* Latest proposal should be on top (#61)

* Colin's magic

* const proposals

* fix to not crash if no denom

* Fabo/wait for stargate to be up (#62)

* debug missing denom

* do not call validators

* await for the remote instance to be up before loading static data

* remove logs

* remove fallback

* comment

* Update cosmosV0-source.js

* Update cosmosV0-source.js

* Update cosmosV0-source.js

* colw/subscription-refactor (#63)

* Factor out subscription object

* WIP

* Reenable subs

* Do not pre-populate cache (temp)

This is run on every request.

* Reenable static data

* Fix

* Remove comment

* WIP

* Use API class within subscription object

* Update file and parameter naming

* Load API classes once.

* Revert "Load API classes once."

ca567095360dbd7a8d81c7a53fe4fe885f3b63d2

* Set headers in separate method

* format comment

* Rename class variable

* Split static data up

* Adjust cache timing, default 5

* Update lib/schema.js

Co-Authored-By: Fabian <[email protected]>

* Change client name to TendermintClient

* Comment and rename for clarity

* Cache specific blocks longer

* Move Tendermint client to CosmosNodeSubscription

* Comments for clarity

* Clear memory after handling each new block (#66)

* Fix typo and no return. (#68)

* Aleksei/sentry added (#67)

* only sentry init code added

* docker-compose changes

* inspect removed

* colw/Decrease validator list loading time (#69)

* Fetch validators each new block and store them

* Store block, and sync validator map with block

* Add block to store

* Remove unused parameters

* Retrieve a single validator form the map

* Review fix: remove height parameter

* Review fix: Change variable name for clarity

* Return delegations and rewards from store (#70)

* Return delegations and rewards from store

* overview values

* Remove unnecessary Promise.all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nylira @faboweb @jbibla