Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build for darwin #57

Closed
nylira opened this issue Nov 14, 2017 · 4 comments
Closed

Cannot build for darwin #57

nylira opened this issue Nov 14, 2017 · 4 comments
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@nylira
Copy link
Contributor

nylira commented Nov 14, 2017

I get this error in my terminal when I run

open cosmos-ui.app/Contents/MacOS/cosmos-ui
/Users/pz/Projects/cosmos-ui/builds/cosmos-ui-darwin-x64/cosmos-ui.app/Contents/MacOS/cosmos-ui; exit
Last login: Tue Nov 14 09:14:25 on ttys000
pz@mbp ~> /Users/pz/Projects/cosmos-ui/builds/cosmos-ui-darwin-x64/cosmos-ui.app/Contents/MacOS/cosmos-ui; exit
(node:6399) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: Path must be a string. Received undefined
(node:6399) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
@nylira nylira added the bug 🐛 issues related to unhandled errors in the code that need to be fixed label Nov 14, 2017
@mappum
Copy link
Contributor

mappum commented Nov 14, 2017

I'm getting this error as well, but it still runs the app just fine. Is the app not running for you after this error?

(BTW, didn't know you could just run the binary inside of the .app and get the stdout, 👍)

@jbibla
Copy link
Collaborator

jbibla commented Nov 15, 2017

when running ...

npm run pack && npm run build:darwin
open builds/cosmos-ui-darwin-x64/cosmos-ui.app

screen shot 2017-11-15 at 8 44 53 am

... electron opens but nothing happens after this alert

@faboweb
Copy link
Collaborator

faboweb commented Nov 21, 2017

Is this still the case?

@nylira
Copy link
Contributor Author

nylira commented Dec 5, 2017

Resolved

@nylira nylira closed this as completed Dec 5, 2017
faboweb pushed a commit that referenced this issue Jun 2, 2020
faboweb added a commit that referenced this issue Jun 2, 2020
faboweb added a commit that referenced this issue Jun 2, 2020
* added node install to docker

* run npm install correct

* don't copy modules

* use env variables for testnet

* Update pr.yml

* github workflows changes

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Make search case-insensitive (#36)

Modify variable names for clarity.

* Query balance by denomination (#48)

* colw/subscription-fix (#47)

* Fix transaction destructure

* Lint

* Rename for consistency

* Override method for V2

* Colw/fix denom and votes (#49)

* Use larger denom for governance parameters

* Lint

* Fix: Leave in big number format for line #86

* Fabo/minor fixes (#51)

* gracefully handle no rewards

* always return balance

* prevent error when no rewards

* fix wrong delegation amount showing

* log transaction if tag is empty (#58)

* fix tally for running proposals (#54)

* Fabo/move testnet definition into network configs file (#56)

* move testnet definition into network configs file

* use configs for endpoints

* update cache key per block (#57)

* colw/minor-fixes (#59)

* Export testnet data for use in LunieDB Source

* Fix get query

* Mario/32 add proposal proposer (#52)

* Add proposal proposer

* Add proposer to proposals page

* Revert package.js mod, use Promise.all

* Call all queries at same time in getProposalById

* Api error 500 fix

* Fabo suggestions

* Add cross-env

* Resolve merge conflict

* Fix merge error

* deliver correct testnet url (#60)

* Latest proposal should be on top (#61)

* Colin's magic

* const proposals

* fix to not crash if no denom

* Fabo/wait for stargate to be up (#62)

* debug missing denom

* do not call validators

* await for the remote instance to be up before loading static data

* remove logs

* remove fallback

* comment

* Update cosmosV0-source.js

* Update cosmosV0-source.js

* Update cosmosV0-source.js

* colw/subscription-refactor (#63)

* Factor out subscription object

* WIP

* Reenable subs

* Do not pre-populate cache (temp)

This is run on every request.

* Reenable static data

* Fix

* Remove comment

* WIP

* Use API class within subscription object

* Update file and parameter naming

* Load API classes once.

* Revert "Load API classes once."

ca567095360dbd7a8d81c7a53fe4fe885f3b63d2

* Set headers in separate method

* format comment

* Rename class variable

* Split static data up

* Adjust cache timing, default 5

* Update lib/schema.js

Co-Authored-By: Fabian <[email protected]>

* Change client name to TendermintClient

* Comment and rename for clarity

* Cache specific blocks longer

* Move Tendermint client to CosmosNodeSubscription

* Comments for clarity

* Clear memory after handling each new block (#66)

* Fix typo and no return. (#68)

* Aleksei/sentry added (#67)

* only sentry init code added

* docker-compose changes

* inspect removed

* colw/Decrease validator list loading time (#69)

* Fetch validators each new block and store them

* Store block, and sync validator map with block

* Add block to store

* Remove unused parameters

* Retrieve a single validator form the map

* Review fix: remove height parameter

* Review fix: Change variable name for clarity

* Return delegations and rewards from store (#70)

* Return delegations and rewards from store

* overview values

* Remove unnecessary Promise.all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Development

No branches or pull requests

4 participants