-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design reward displaying and claiming #2010
Comments
Note: You can’t withdraw a custom amount and you can withdraw all your rewards (from all validators) at once or all from a specific validator |
I propose we only allow claiming all at once for now and implement the more specific version if requested. |
agreed. claim all or none at all. should still be an input on the action modal - just readonly. |
This might not work as the amount displayed on the amount field can differ from the actual amount withdrawn (i.e displayed < withdrawn) |
imho showing the rewards on the header is a bad idea because of #2044. Also displaying it together with balance will bloat the header. It'd be better to have show and claim rewards on the wallet or my delegations page, preferably on the former |
Let's go with Jordans solution for now and see where we can improve in a later iteration. |
is |
Then we should fix #2044 first |
But I think it's better to get it right now instead of refactor everything later on |
@fedekunze how would this work? |
i think balance and rewards are the two most important pieces of information for our users. perhaps the font size is too big, but this info is critical. let's leave it for now and see what it feels like when we actually have balances and rewards for a while. |
Ref #1306
AC:
The text was updated successfully, but these errors were encountered: