Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design reward displaying and claiming #2010

Closed
2 tasks done
faboweb opened this issue Feb 19, 2019 · 13 comments
Closed
2 tasks done

Design reward displaying and claiming #2010

faboweb opened this issue Feb 19, 2019 · 13 comments
Assignees
Labels
design-work-needed 🎨 issues that require design work before development

Comments

@faboweb
Copy link
Collaborator

faboweb commented Feb 19, 2019

Ref #1306

AC:

  • have a design for displaying rewards
  • have a design for claiming rewards (action modal)
@faboweb faboweb added design-work-needed 🎨 issues that require design work before development rewards 🤑 labels Feb 19, 2019
@jbibla
Copy link
Collaborator

jbibla commented Feb 22, 2019

Claiming all rewards at once:
screen shot 2019-02-22 at 10 04 52 am

Claiming reward action modal:
screen shot 2019-02-22 at 10 50 33 am

Rewards on page validator:
screen shot 2019-02-22 at 10 53 33 am

Rewards on validator li:
screen shot 2019-02-22 at 10 55 35 am

@jbibla
Copy link
Collaborator

jbibla commented Feb 22, 2019

@fedekunze

@jbibla jbibla closed this as completed Feb 22, 2019
@jbibla jbibla mentioned this issue Feb 22, 2019
5 tasks
@fedekunze
Copy link
Contributor

Note: You can’t withdraw a custom amount and you can withdraw all your rewards (from all validators) at once or all from a specific validator

@faboweb
Copy link
Collaborator Author

faboweb commented Feb 24, 2019

I propose we only allow claiming all at once for now and implement the more specific version if requested.

@jbibla
Copy link
Collaborator

jbibla commented Feb 24, 2019

agreed. claim all or none at all. should still be an input on the action modal - just readonly.

@fedekunze
Copy link
Contributor

should still be an input on the action modal - just readonly.

This might not work as the amount displayed on the amount field can differ from the actual amount withdrawn (i.e displayed < withdrawn)

@fedekunze
Copy link
Contributor

fedekunze commented Feb 26, 2019

imho showing the rewards on the header is a bad idea because of #2044. Also displaying it together with balance will bloat the header. It'd be better to have show and claim rewards on the wallet or my delegations page, preferably on the former

This was referenced Feb 26, 2019
@faboweb
Copy link
Collaborator Author

faboweb commented Feb 26, 2019

Let's go with Jordans solution for now and see where we can improve in a later iteration.

@faboweb
Copy link
Collaborator Author

faboweb commented Feb 26, 2019

This might not work as the amount displayed on the amount field can differ from the actual amount withdrawn (i.e displayed < withdrawn)

is withdrawn > displayed so bad? :)

@fedekunze
Copy link
Contributor

Let's go with Jordans solution for now and see where we can improve in a later iteration.

Then we should fix #2044 first

@fedekunze
Copy link
Contributor

But I think it's better to get it right now instead of refactor everything later on

@jbibla
Copy link
Collaborator

jbibla commented Feb 26, 2019

This might not work as the amount displayed on the amount field can differ from the actual amount withdrawn (i.e displayed < withdrawn)

@fedekunze how would this work?

@jbibla
Copy link
Collaborator

jbibla commented Feb 26, 2019

imho showing the rewards on the header is a bad idea because of #2044. Also displaying it together with balance will bloat the header. It'd be better to have show and claim rewards on the wallet or my delegations page, preferably on the former

i think balance and rewards are the two most important pieces of information for our users. perhaps the font size is too big, but this info is critical. let's leave it for now and see what it feels like when we actually have balances and rewards for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-work-needed 🎨 issues that require design work before development
Projects
None yet
Development

No branches or pull requests

3 participants