Show commission earned

[faboweb]

I as a user
Want to see the amount of commission I earned
So that I stay engaged in holding atoms.

AC:

• a user should be able to see how many rewards they have been issued from each validator they have delegated to
• a user should be able to see a sum of the total rewards he has in all validators
• rewards should update in the UI as they update

See following event for updates on rewards (taken from https://github.com/cosmos/cosmos-sdk/blob/develop/docs/spec/distribution/state.md):

dependencies: #209

[jbibla]

delegators don't earn commissions. technically, they are issued "fee shares" for staking their Atom's.

• a user should be able to see how many fee shares they have been issued from each validator they have delegated to.
• we should display the approximate value of these fee shares

since this takes place on the client we should store it locally. in the event that there is a bug or the data is erased or disappears for any reason it is possible to query for this information. but we should store it locally by default.

if we need to calculate this — the math can be found in the gaia repo spec.

yo @rigelrozanski how'd i do? ✌️

[rigelrozanski]

Yes - each delegator receives fees shares, and are encouraged to withdraw their fee reward with a reasonable frequency. When withdrawing fees all fee shares they have accumulated must be withdrawn at once (backend requirement). Note that this is totally different from withdrawing atom provisions which are by default bonded, meaning that to withdraw them they must be unbonded. @jolesbi you did well - next thing you need to do is dig up the math from the spec! hehe I can help with this if you get stuck, there is a lot in there.

[NodeGuy]

next thing you need to do is dig up the math from the spec! hehe I can help with this if you get stuck, there is a lot in there.

Holy cow there's a lot in there, @rigelrozanski! Thanks for your offer of help. I see the cosmos/gaia repository is now deprecated in favor of cosmos-sdk. Would you please point us to the relevant document within cosmos-sdk (I can't find it) and extract for us the formulas we need?

[rigelrozanski]

@NodeGuy - PR just being finalized now - you can look at everything in this dir. (https://github.com/cosmos/cosmos-sdk/tree/rigel/piggy-bank-fee-spec/docs/spec/distribution)

*note don't bother looking in the WIP folder - that's a more complicated mechanism which will not be implemented for a while

[NodeGuy]

Thank you. We'll take a look when the PR is merged.

[rigelrozanski]

@NodeGuy PR is now merged - https://github.com/cosmos/cosmos-sdk/tree/develop/docs/spec/distribution

[NodeGuy]

Thank you. Blocked by #1285.

[fedekunze]

see comments on #2010